Date: Sun, 12 Sep 2004 04:38:41 +0200 (CEST) From: Dan Lukes <dan@obluda.cz> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/71631: [PATCH] cleanup of the usr.sbin/pppctl code Message-ID: <200409120238.i8C2cfV6007122@kulesh.obluda.cz> Resent-Message-ID: <200409120240.i8C2eV2c087178@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 71631
>Category: bin
>Synopsis: [PATCH] cleanup of the usr.sbin/pppctl code
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Sep 12 02:40:30 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Dan Lukes
>Release: FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
usr.sbin/pppctl/pppctl.c,v 1.32 2003/12/07 08:39:29 tjr
>Description:
There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.
Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.
I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.
usr.sbin/pppctl/pppctl.c:368: warning: 'fd' might be used uninitialized in this function
'fd' is initialized with no exception, so turn-off warning only
>How-To-Repeat:
N/A
>Fix:
*** usr.sbin/pppctl/pppctl.c.ORIG Sun Dec 7 23:02:31 2003
--- usr.sbin/pppctl/pppctl.c Sat Sep 11 13:42:01 2004
***************
*** 365,371 ****
main(int argc, char **argv)
{
struct sockaddr_un ifsun;
! int n, arg, fd, len, verbose, save_errno, hide1, hide1off, hide2;
unsigned TimeoutVal;
char *DoneWord = "x", *next, *start;
struct sigaction act, oact;
--- 365,372 ----
main(int argc, char **argv)
{
struct sockaddr_un ifsun;
! int n, arg, len, verbose, save_errno, hide1, hide1off, hide2;
! int fd = fd; /* init to avoid "might be used unitialized" warning 8/
unsigned TimeoutVal;
char *DoneWord = "x", *next, *start;
struct sigaction act, oact;
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409120238.i8C2cfV6007122>