Date: Fri, 22 Jul 2016 09:17:53 -0400 From: Kris Moore <kris@ixsystems.com> To: Adam Weinberger <adamw@adamw.org>, Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Kris Moore <kmoore@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: [SPAM] Re: svn commit: r418889 - in head/deskutils: . copyq Message-ID: <bf8a0d42-7a2a-58a7-4b44-07c99f454f47@ixsystems.com> In-Reply-To: <91496634-0037-4256-951C-F8A8ABF284A9@adamw.org> References: <201607211847.u6LIluTh087613@repo.freebsd.org> <20160722044657.GC37437@FreeBSD.org> <91496634-0037-4256-951C-F8A8ABF284A9@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/22/2016 00:56, Adam Weinberger wrote: >> On 21 Jul, 2016, at 22:46, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: >> >> On Thu, Jul 21, 2016 at 06:47:56PM +0000, Kris Moore wrote: >>> New Revision: 418889 >>> URL: https://svnweb.freebsd.org/changeset/ports/418889 >>> >>> Log: >>> CopyQ is advanced clipboard manager with editing and scripting features. >>> >>> WWW: https://github.com/hluk/CopyQ >>> >>> [...] >>> +USE_XORG+= x11 xfixes xtst >> What's the reason for += here? >> >>> +USE_QT5= core gui network svg multimedia imageformats \ >> Spaces were used in this line instead of proper tab. >> >>> +USE_GL+= gl >> Bogus += again. >> >>> +USES= qmake >> Spaces again; also it's better to place more generic USES *before* specific >> USE_FOO knobs. >> >>> +PLIST_FILES= bin/copyq >> PLIST-related knobs should be among the last ones (after USE* knobs, but >> before OPTIONS* knobs). > AFAIK we've never specified ordering after _DEPENDS. FWIW, Kris's ordering makes sense to me; the variables are ordered by decreasing probability of future modification. Though I do agree about all the +='s. > > # Adam > > Fixed those, thanks guys! -- Kris Moore iXsystems Enterprise Storage & Servers Driven By Open Source
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bf8a0d42-7a2a-58a7-4b44-07c99f454f47>