From owner-freebsd-testing@FreeBSD.ORG Mon Mar 3 18:40:25 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9B6AAEDD; Mon, 3 Mar 2014 18:40:25 +0000 (UTC) Received: from mail-ve0-x236.google.com (mail-ve0-x236.google.com [IPv6:2607:f8b0:400c:c01::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 445F1C11; Mon, 3 Mar 2014 18:40:25 +0000 (UTC) Received: by mail-ve0-f182.google.com with SMTP id jw12so1263563veb.41 for ; Mon, 03 Mar 2014 10:40:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=370eYkIMX5flgZniDrJn7LeMi8cw+sbFAKM5mMNRv0M=; b=lPsJOXbIIqRjZgCpLCsP9oZpAEd3KzTiCjDZCtTueg30/wixp0VlkpXK7KRBJnwAcQ uyxsP1TKDFBqKWYUFhldwlOgiul7TogksodV0CK6RXzRW9nF6W/CmSaYfusll2FRRbR+ ihW3A1sKxa0QItUZ8Q7ZTmhlhhuFxn+1K08BXLE9JQB8hkVGbVRNMIFuvuwOMwdDP0qd /V/IlkCROXfuLaIOje347VdZY8n6/iUnP+zMGCfTW1QkZNTx866xCJKqkmkDdAkI0v2Q A0Ke4ApTCVfKQp0J0DC/2vbhjeQbiTikXV2B7/cz9XVj0Wv1WJMbMeRmEWOn6+N6+j7K qeUA== MIME-Version: 1.0 X-Received: by 10.58.161.46 with SMTP id xp14mr127137veb.37.1393872024407; Mon, 03 Mar 2014 10:40:24 -0800 (PST) Received: by 10.221.67.136 with HTTP; Mon, 3 Mar 2014 10:40:24 -0800 (PST) In-Reply-To: References: <20140124162759.GB90996@stack.nl> <0A68C9FE-6A3A-4DCF-92A9-A506D7581D69@gmail.com> <96373EF8-77EA-4AA6-8422-63881C32E455@gmail.com> Date: Mon, 3 Mar 2014 10:40:24 -0800 Message-ID: Subject: Re: [PATCH v2] convert /bin/sh tests over to ATF From: Garrett Cooper To: Julio Merino Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-testing@freebsd.org" , Jilles Tjoelker X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Mar 2014 18:40:25 -0000 On Sun, Mar 2, 2014 at 1:14 PM, Julio Merino wrote: > On Mon, Jan 27, 2014 at 5:02 AM, Garrett Cooper wrote: >> Hi all, >> Here's the next patch for converting bin/sh/tests over to ATF. I've tried to incorporate all input from folks about simplifying the integration scripts and removing valid_osreldate functionality. > > Apologies for the really long delay... I suppose nothing has changed > given that there were no replies to this. Soooo, some more comments: > > * Could functional_test be created with ATF_TESTS_SH ? Yes. > * Rename the script in subversion to functional_test.sh (including the > extension). It's just in my git fork; I'll rename it (good catch). > * Do NOT cd out of the current work directory in functional_test, > anywhere. This breaks all the assumptions in tests regarding the > ability to write to the current work directory without caring about > cleaning up. > > * Use atf_get_srcdir to locate where the data files are, not dirname $0. Ok. > * Continue to use SUBDIR, not ATF_TESTS_SUBDIRS. The latter does not exist. Ok. > * Reintroduce $FreeBSD$ to functional_test.sh. Ok. > * The empty Makefiles in all the subdirectories are quite confusing. > At the very least, explicitly define TESTSDIR as is customary > everywhere else. I guess I could. It just seems redundant, but there aren't a ton of Makefiles. > * I'm still afraid of all this "auto-discovery" of test cases based on > files, because it is quite confusing... but at least it's now a bit > more self-contained and easier to strip out later. So we could keep > it. Well, it would be better if this auto-discovery of testcases was a generic driver that mimicked prove, but I understand your concern. That being said, it seems like it would fit better in a different location. > * The FILES must continue to be installed. Does this actually work > when running your test programs after a "make install"? Could you please clarify your concern here? I'm not sure I understood what you meant. > Cheers Thank you :)! -Garrett