From owner-freebsd-current@FreeBSD.ORG  Sun Sep  4 22:46:53 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 55FFD16A41F;
	Sun,  4 Sep 2005 22:46:53 +0000 (GMT)
	(envelope-from gavin.atkinson@ury.york.ac.uk)
Received: from mail-gw1.york.ac.uk (mail-gw1.york.ac.uk [144.32.128.246])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B8EDF43D45;
	Sun,  4 Sep 2005 22:46:52 +0000 (GMT)
	(envelope-from gavin.atkinson@ury.york.ac.uk)
Received: from ury.york.ac.uk (ury.york.ac.uk [144.32.108.81])
	by mail-gw1.york.ac.uk (8.12.10/8.12.10) with ESMTP id j84Mkok2015962; 
	Sun, 4 Sep 2005 23:46:50 +0100 (BST)
Received: from ury.york.ac.uk (localhost.york.ac.uk [127.0.0.1])
	by ury.york.ac.uk (8.13.1/8.13.1) with ESMTP id j84N1Gjd031295;
	Mon, 5 Sep 2005 00:01:16 +0100 (BST)
	(envelope-from gavin.atkinson@ury.york.ac.uk)
Received: from localhost (gavin@localhost)
	by ury.york.ac.uk (8.13.1/8.13.1/Submit) with ESMTP id j84N1GmQ031292; 
	Mon, 5 Sep 2005 00:01:16 +0100 (BST)
	(envelope-from gavin.atkinson@ury.york.ac.uk)
X-Authentication-Warning: ury.york.ac.uk: gavin owned process doing -bs
Date: Mon, 5 Sep 2005 00:01:16 +0100 (BST)
From: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
X-X-Sender: gavin@ury.york.ac.uk
To: John Baldwin <jhb@freebsd.org>
In-Reply-To: <20050904234626.H31032@ury.york.ac.uk>
Message-ID: <20050904235509.J31032@ury.york.ac.uk>
References: <200508311636.49278.jhb@FreeBSD.org>
	<20050904234626.H31032@ury.york.ac.uk>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-York-MailScanner: Found to be clean
X-York-MailScanner-From: gavin.atkinson@ury.york.ac.uk
Cc: current@freebsd.org
Subject: Re: [PATCH] Locking fixes for tl(4)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Sep 2005 22:46:53 -0000

On Sun, 4 Sep 2005, Gavin Atkinson wrote:
> On Wed, 31 Aug 2005, John Baldwin wrote:
>
>> Patch fixes locking for tl(4) and marks it MPSAFE.  Please test, thanks!
>> 
>> http://www.FreeBSD.org/~jhb/patches/tl_locking.patch
>
> Doesn't work, I'm afraid.  Panic on attach:

... because tl_hardreset() is called before sc->tl_ifp is allocated.  I'm 
recompiling now, having moved the if_alloc and related code to before the 
first hardreset() call.

Gavin