Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Apr 1998 15:04:24 +1000
From:      Bruce Evans <bde@zeta.org.au>
To:        brian@FreeBSD.ORG, cvs-committers@FreeBSD.ORG
Subject:   Re: cvs commit: src/usr.sbin/ppp bundle.c fsm.c id.c ipcp.c lcp.c log.h lqr.c modem.c prompt.h sig.c slcompress.c timer.c
Message-ID:  <199804200504.PAA05579@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>brian       1998/04/19 16:09:15 PDT
>
>  Modified files:        (Branch: MP)
>    usr.sbin/ppp         bundle.c fsm.c id.c ipcp.c lcp.c log.h 
>                         lqr.c modem.c prompt.h sig.c slcompress.c 
>                         timer.c 
>  Log:
>  o Use __attribute__ (#ifdef __GNUC__) to type-check
>    LogPrintf() and prompt_Printf(), and fix the bits
>    identified as being wrong as a result.

Ifdefing the use of __attribute__ is unnecessary because <sys/cdefs.h>
already defines away __attribute__ (#if __GNUC__ < 2).

Defining away __attribute__ is not quite right.  Cases where __attribute__
is used to change the semantics just become wrong if __attribute__ is
defined away.  We currently avoid this problem by only using __attribute__
for non-semantic things, but I want to use it to define nonstandard types
(see <stdio.h> and the error output for building ncal as part of
`make world').

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199804200504.PAA05579>