From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jun 18 12:20:05 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B8B3106567F for ; Wed, 18 Jun 2008 12:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1F0BE8FC1F for ; Wed, 18 Jun 2008 12:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m5ICK5LD067743 for ; Wed, 18 Jun 2008 12:20:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m5ICK5Yv067742; Wed, 18 Jun 2008 12:20:05 GMT (envelope-from gnats) Resent-Date: Wed, 18 Jun 2008 12:20:05 GMT Resent-Message-Id: <200806181220.m5ICK5Yv067742@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stefan Sperling Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E35A106564A for ; Wed, 18 Jun 2008 12:18:46 +0000 (UTC) (envelope-from stsp@stsp.name) Received: from einhorn.in-berlin.de (einhorn.in-berlin.de [192.109.42.8]) by mx1.freebsd.org (Postfix) with ESMTP id A8F748FC1A for ; Wed, 18 Jun 2008 12:18:45 +0000 (UTC) (envelope-from stsp@stsp.name) Received: from stsp.name (ted.stsp.name [217.197.84.186]) (authenticated bits=128) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id m5IBelaH002208 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Wed, 18 Jun 2008 13:40:49 +0200 Received: from ted.stsp.name (localhost [127.0.0.1]) by stsp.name (8.14.2/8.14.2) with ESMTP id m5IBek7I040652 for ; Wed, 18 Jun 2008 13:40:46 +0200 (CEST) (envelope-from stsp@ted.stsp.name) Received: (from stsp@localhost) by ted.stsp.name (8.14.2/8.14.2/Submit) id m5IBekBv040650; Wed, 18 Jun 2008 13:40:46 +0200 (CEST) (envelope-from stsp) Message-Id: <200806181140.m5IBekBv040650@ted.stsp.name> Date: Wed, 18 Jun 2008 13:40:46 +0200 (CEST) From: Stefan Sperling To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/124712: x11-themes/clearlooks-themes does not build X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Stefan Sperling List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jun 2008 12:20:05 -0000 >Number: 124712 >Category: ports >Synopsis: x11-themes/clearlooks-themes does not build >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jun 18 12:20:04 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Stefan Sperling >Release: FreeBSD 7.0-RELEASE i386 >Organization: >Environment: System: FreeBSD ted.stsp.name 7.0-RELEASE FreeBSD 7.0-RELEASE #2: Sat Mar 29 23:54:21 CET 2008 stsp@ted.stsp.name:/usr/obj/home/stsp/src/freebsd-7.0/sys/TED i386 >Description: It seems that an attempt to fix a build failure of this port did not really fix it. When trying to install this port, is errors out with: Gnome/gtk-engine users should use /usr/ports/x11-themes/clearlooks-themes instead *** Error code 1 This is because the Makefile of the master port (x11-themes/clearlooks) uses ${PORTNAME} to determine which port it is building: A recent commit changed the PORTNAME of x11-themes/clearlooks-themes from "clearlooks-themes" to just "clearlooks", which makes the Makefile think the master port is being built, even though the sub-port is being built. ---------------------------- revision 1.3 date: 2008/04/22 08:33:35; author: miwi; state: Exp; lines: +2 -1 - Fix build after xorg cleanup Submitted by: pointyhat $ cvs diff -r1.2 -r1.3 Makefile Index: Makefile =================================================================== RCS file: /usr/ncvs/ports/x11-themes/clearlooks-themes/Makefile,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- Makefile 13 Apr 2005 16:50:05 -0000 1.2 +++ Makefile 22 Apr 2008 08:33:35 -0000 1.3 @@ -2,10 +2,11 @@ # Date created: 2005-04-12 # Whom: Michael Johnson # -# $FreeBSD: ports/x11-themes/clearlooks-themes/Makefile,v 1.2 2005/04/13 16:50:05 ahze Exp $ +# $FreeBSD: ports/x11-themes/clearlooks-themes/Makefile,v 1.3 2008/04/22 08:33:35 miwi Exp $ # -PORTNAME= clearlooks-themes +PORTNAME= clearlooks +PKGNAMESUFFIX+= -themes COMMENT= Clearlooks themes with the engine coming from gtk-engines2 Whatever this commit tried to fix exactly (sadly, the log message does not say), the fix is clearly wrong. >How-To-Repeat: cd /usr/ports/x11-themes/clearlooks-themes && make >Fix: This patch makes x11-themes/clearlooks-themes build again. I have no idea whether this has any effect on the original problem which the commit tried to fix, because I don't have any information on what the original problem was beyond the terse hint provided in the commit's log message. Apart from changing the PORTNAME back to "clearlooks-themes", it also fixes a problem with the distfile's name -- if DISTNAME is left at its default value, the port cannot build because it will assume a distname that does not match what's in the master port's distinfo file. Index: Makefile =================================================================== RCS file: /usr/ncvs/ports/x11-themes/clearlooks-themes/Makefile,v retrieving revision 1.3 diff -u -r1.3 Makefile --- Makefile 22 Apr 2008 08:33:35 -0000 1.3 +++ Makefile 18 Jun 2008 11:19:22 -0000 @@ -2,11 +2,13 @@ # Date created: 2005-04-12 # Whom: Michael Johnson # -# $FreeBSD: ports/x11-themes/clearlooks-themes/Makefile,v 1.3 2008/04/22 08:33:35 miwi Exp $ +# $FreeBSD: ports/x11-themes/clearlooks-themes/Makefile,v 1.2 2005/04/13 16:50:05 ahze Exp $ # -PORTNAME= clearlooks -PKGNAMESUFFIX+= -themes +PORTNAME= clearlooks-themes +# XXX: PORTVERSION needs to be kept in sync with the master port. +PORTVERSION= 0.6.2 +DISTNAME= clearlooks-${PORTVERSION} COMMENT= Clearlooks themes with the engine coming from gtk-engines2 >Release-Note: >Audit-Trail: >Unformatted: