From owner-svn-ports-head@freebsd.org Thu Aug 25 09:45:31 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 98BE3BC5986; Thu, 25 Aug 2016 09:45:31 +0000 (UTC) (envelope-from crees@physics.org) Received: from mail37c50.megamailservers.eu (mail37c50.megamailservers.eu [91.136.10.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5A9BA1CFB; Thu, 25 Aug 2016 09:45:29 +0000 (UTC) (envelope-from crees@physics.org) X-Authenticated-User: bayofrum.uwclub.net Received: from pegasus.bayofrum.net (host-2-102-106-111.as13285.net [2.102.106.111]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id u7P8RMWj012176; Thu, 25 Aug 2016 08:27:24 +0000 Received: from android-4497c5999ce4d9aa.bayofrum.net (android-4497c5999ce4d9aa.bayofrum.net [192.168.1.115]) by pegasus.bayofrum.net (Postfix) with ESMTPSA id 398704D6DF; Thu, 25 Aug 2016 09:26:04 +0100 (BST) User-Agent: K-9 Mail for Android In-Reply-To: <201608250020.u7P0K1GM086639@repo.freebsd.org> References: <201608250020.u7P0K1GM086639@repo.freebsd.org> MIME-Version: 1.0 Subject: Re: svn commit: r420828 - head/net/py-nnpy From: Chris Rees Date: Thu, 25 Aug 2016 09:26:06 +0100 To: Kevin Lo , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <5416C91F-F57A-4078-8E6A-A15CC195C1DC@physics.org> X-bayofrum-MailScanner-Information: Please contact the ISP for more information X-bayofrum-MailScanner-ID: 398704D6DF.A360C X-bayofrum-MailScanner: Found to be clean X-bayofrum-MailScanner-From: crees@physics.org X-Spam-Status: No X-CTCH-RefID: str=0001.0A0B0202.57BEABEC.01D5, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.1 cv=R/Y6R7hX c=1 sm=1 tr=0 a=gIyif6r13gc5Hj8RuoB4yw==:117 a=gIyif6r13gc5Hj8RuoB4yw==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=7z1cN_iqozsA:10 a=6I5d2MoRAAAA:8 a=pAC1E_1pqs4y2y8ikHoA:9 a=QEXdDO2ut3YA:10 a=Y6gCyGHSAAAA:8 a=pT_BhkXyAAAA:8 a=P0S6o3SJAAAA:8 a=A7h86ReRLpLUIe0PW9MA:9 a=dsiBnRKHBJjyEcwH:21 a=_W_S_7VecoQA:10 a=-FEs8UIgK8oA:10 a=NWVoK91CQyQA:10 a=IjZwj45LgO3ly-622nXo:22 a=tlvBmHzrBop7jaH_zIyQ:22 a=vIQ_XZNehzJrW-gsp8Y6:22 a=WH_0ghv6r2uJcVQkXlWi:22 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2016 09:45:31 -0000 Hi Kevin, You should really either expand BUILD_DEPENDS before assigning it, with := or assign BUILD_DEPENDS to RUN_DEPENDS instead. Doing that avoids pollution from later additions such as extra USES only used for build etc. PORTREVISION was unnecessary here too :) Cheers, Chris On 25 August 2016 01:20:01 BST, Kevin Lo wrote: >Author: kevlo >Date: Thu Aug 25 00:20:00 2016 >New Revision: 420828 >URL: https://svnweb.freebsd.org/changeset/ports/420828 > >Log: > Add missing BUILD_DEPENDS. > > Spotted by: koobs > >Modified: > head/net/py-nnpy/Makefile > >Modified: head/net/py-nnpy/Makefile >============================================================================== >--- head/net/py-nnpy/Makefile Wed Aug 24 23:49:06 2016 (r420827) >+++ head/net/py-nnpy/Makefile Thu Aug 25 00:20:00 2016 (r420828) >@@ -2,6 +2,7 @@ > > PORTNAME= nnpy > PORTVERSION= 1.2 >+PORTREVISION= 1 > CATEGORIES= net python > MASTER_SITES= CHEESESHOP > PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} >@@ -12,7 +13,8 @@ COMMENT= cffi-based Python bindings for > LICENSE= MIT > > LIB_DEPENDS= libnanomsg.so:net/nanomsg >-RUN_DEPENDS= ${PYTHONPREFIX_SITELIBDIR}/_cffi_backend.so:devel/py-cffi >+BUILD_DEPENDS= ${PYTHONPREFIX_SITELIBDIR}/_cffi_backend.so:devel/py-cffi >+RUN_DEPENDS= ${BUILD_DEPENDS} > > USES= python > USE_PYTHON= autoplist distutils > > >-- >This message has been scanned for viruses and >dangerous content by MailScanner, and is >believed to be clean. -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.