Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 08 Oct 2003 17:47:22 +0200
From:      Oliver Eikemeier <eikemeier@fillmore-labs.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        Joe Marcus Clarke <marcus@FreeBSD.org>
Subject:   ports/57751: [PATCH] port devel/portlint: check for NOPORTSDOC
Message-ID:  <3F84318A.5070505@fillmore-labs.com>
Resent-Message-ID: <200310081550.h98FoLcH062924@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         57751
>Category:       ports
>Synopsis:       [PATCH] port devel/portlint: check for NOPORTSDOC
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 08 08:50:21 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Oliver Eikemeier
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
Fillmore Labs - http://www.fillmore-labs.com
>Environment:
System: FreeBSD nuuk.fillmore-labs.com 4.8-STABLE

>Description:

The usage of NOPORTSDOC seems to be a common error, see PR 53911 and PR 57749.

>How-To-Repeat:
>Fix:

Proposed patch below. Additionally either the portrevision or the
portversion should be bumped.

--- portlint-NOPORTSDOC.patch begins here ---
--- devel/portlint/src/portlint.pl.orig	16 Aug 2003 20:42:44 -0000
+++ devel/portlint/src/portlint.pl	8 Oct 2003 15:37:01 -0000
@@ -875,6 +875,9 @@
 		}
 	}
 	print "OK: checking for use of NOPORTDOCS.\n" if ($verbose);
+	if ($whole =~ /NOPORTSDOC/) {
+		&perror("WARN: NOPORTSDOC found. Do you mean NOPORTDOCS?");
+	}
 	if ($sharedocused && $whole !~ /defined\(NOPORTDOCS\)/
 	 && $whole !~ m#(\$[\{\(]PREFIX[\}\)]|$localbase)/share/doc#) {
 		&perror("WARN: use \".if !defined(NOPORTDOCS)\" to wrap ".
--- portlint-NOPORTSDOC.patch ends here ---




>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3F84318A.5070505>