Date: Sat, 26 Sep 2009 15:14:44 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Jilles Tjoelker <jilles@stack.nl> Cc: gavin@freebsd.org, freebsd-current@freebsd.org, brian@freebsd.org Subject: Re: Revision 196634 of sh(1) breaks lp(1) Message-ID: <20090926221444.GA55696@troutmask.apl.washington.edu> In-Reply-To: <20090926213130.GA88702@stack.nl> References: <20090926185128.GA53658@troutmask.apl.washington.edu> <20090926213130.GA88702@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 26, 2009 at 11:31:30PM +0200, Jilles Tjoelker wrote: > On Sat, Sep 26, 2009 at 11:51:28AM -0700, Steve Kargl wrote: > > troutmask:sgk[208] cat .cshrc | lp -d pug > > /usr/bin/lpr: cannot access > > > troutmask:sgk[209] uname -a > > FreeBSD troutmask.apl.washington.edu 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r197195M: > > Mon Sep 14 11:11:46 PDT 2009 > > kargl@troutmask.apl.washington.edu:/usr/obj/usr/src/sys/SPEW amd64 > > The problem seems not because of r196634 of sh(1), but because of > r194171 of lp(1) (see also PR standards/129554). As of that revision, > lp passes an empty filename to lpr if the new -t option is not used. > lpr cannot access that file and prints the error message. > > The attached patch should fix the issue, and should also avoid invalid > arguments to lpr if an empty title is given. > > I use CUPS and not FreeBSD lpr so I just checked that the lpr command > looks right in sh -x. > The patch appears to works. Thanks. Sorry about pointing at the recent sh(1) changes. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090926221444.GA55696>