Date: Sun, 03 Dec 2017 19:35:59 +0100 From: "Kristof Provost" <kp@FreeBSD.org> To: "Alan Somers" <asomers@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r326497 - in head: etc/mtree tests/sys tests/sys/netipsec tests/sys/netipsec/tunnel Message-ID: <D0CA8D17-6A07-488E-BEF4-DC20C31809B3@FreeBSD.org> In-Reply-To: <CAOtMX2g8dU6v%2BPam3akQKO8zVVWJjWwbY%2B0LX-FYjkdsi2sH5A@mail.gmail.com> References: <201712031352.vB3DqZF3084841@repo.freebsd.org> <CAOtMX2g8dU6v%2BPam3akQKO8zVVWJjWwbY%2B0LX-FYjkdsi2sH5A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3 Dec 2017, at 19:20, Alan Somers wrote: > On Sun, Dec 3, 2017 at 6:52 AM, Kristof Provost <kp@freebsd.org> wrote: > >> Author: kp >> Date: Sun Dec 3 13:52:35 2017 >> New Revision: 326497 >> URL: https://svnweb.freebsd.org/changeset/base/326497 >> >> Log: >> Add IPSec tests in tunnel mode >> >> Some IPSec in tunnel mode allowing to test multiple IPSec >> configurations. These tests are reusing the jail/vnet scripts from pf >> tests for generating complex network. >> >> Submitted by: olivier@ >> Differential Revision: https://reviews.freebsd.org/D13017 >> > It's not ok to use kldunload during the test heads. Everything in the > head methods gets executed when you do "kyua list". Anything output gets > interpreted by Kyua. In this case, if kldunload outputs anything at all, > Kyua will consider it to be a syntax error, and it will skip the entire > file. You should limit yourself to using just atf_set in the header. Move > the kld commands into the test case bodies. > Thanks. Done in r326500. Regards, Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D0CA8D17-6A07-488E-BEF4-DC20C31809B3>