Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 21 Feb 2021 16:42:29 GMT
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: a310973472b5 - releng/13.0 - pf: Fix osfp configuration
Message-ID:  <202102211642.11LGgTMm039390@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch releng/13.0 has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=a310973472b56a1c224ba76ffaa5adff7211f244

commit a310973472b56a1c224ba76ffaa5adff7211f244
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2021-02-18 07:36:46 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2021-02-21 16:31:27 +0000

    pf: Fix osfp configuration
    
    pf_rule_to_krule() incorrectly converted the rule osfp configuration to
    the krule structure.
    
    Approved by:    re (kib)
    Reported by:    delphij@
    MFC after:      3 days
    
    (cherry picked from commit 2ed689a674c380e48245933d5326da4dda65f94d)
    (cherry picked from commit 9823eb6909fcd82bb9d70e77037542e527e3d6ff)
---
 sys/netpfil/pf/pf_ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c
index edc8443dcc0a..bd8896cfb772 100644
--- a/sys/netpfil/pf/pf_ioctl.c
+++ b/sys/netpfil/pf/pf_ioctl.c
@@ -1623,7 +1623,7 @@ pf_rule_to_krule(const struct pf_rule *rule, struct pf_krule *krule)
 	/* Don't allow userspace to set evaulations, packets or bytes. */
 	/* kif, anchor, overload_tbl are not copied over. */
 
-	krule->os_fingerprint = krule->os_fingerprint;
+	krule->os_fingerprint = rule->os_fingerprint;
 
 	krule->rtableid = rule->rtableid;
 	bcopy(rule->timeout, krule->timeout, sizeof(krule->timeout));



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202102211642.11LGgTMm039390>