From owner-freebsd-current@FreeBSD.ORG  Wed Aug 25 18:17:49 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A4ED416A4CE; Wed, 25 Aug 2004 18:17:49 +0000 (GMT)
Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7A8A843D3F; Wed, 25 Aug 2004 18:17:49 +0000 (GMT)
	(envelope-from obrien@NUXI.com)
Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1])
	by TRANG.nuxi.com (8.13.1/8.12.11) with ESMTP id i7PIHcw1056573;
	Wed, 25 Aug 2004 11:17:38 -0700 (PDT)
	(envelope-from obrien@dragon.nuxi.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i7PIHU8b055749;
	Wed, 25 Aug 2004 11:17:30 -0700 (PDT)
	(envelope-from obrien)
Date: Wed, 25 Aug 2004 11:17:30 -0700
From: "David O'Brien" <obrien@freebsd.org>
To: Sean McNeil <sean@mcneil.com>
Message-ID: <20040825181730.GJ53710@dragon.nuxi.com>
Mail-Followup-To: David O'Brien <obrien@FreeBSD.org>,
	Sean McNeil <sean@mcneil.com>, Harti Brandt <harti@freebsd.org>,
	Giorgos Keramidas <keramida@ceid.upatras.gr>,
	Tim Kientzle <kientzle@freebsd.org>, current@freebsd.org
References: <1092777586.92327.9.camel@server.mcneil.com>
	<1093369220.10362.6.camel@server.mcneil.com>
	<20040824200225.V517@beagle.kn.op.dlr.de>
	<1093371600.10464.23.camel@server.mcneil.com>
	<20040824205417.L517@beagle.kn.op.dlr.de>
	<1093377802.43728.11.camel@server.mcneil.com>
	<1093385848.84723.2.camel@server.mcneil.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1093385848.84723.2.camel@server.mcneil.com>
User-Agent: Mutt/1.4.1i
X-Operating-System: FreeBSD 6.0-CURRENT
Organization: The NUXI BSD Group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
cc: Giorgos Keramidas <keramida@ceid.upatras.gr>
cc: Tim Kientzle <kientzle@freebsd.org>
cc: Harti Brandt <harti@freebsd.org>
cc: current@freebsd.org
Subject: Re: bsdtar core dumps
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: obrien@freebsd.org
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Aug 2004 18:17:49 -0000

On Tue, Aug 24, 2004 at 03:17:28PM -0700, Sean McNeil wrote:
> > > SM>> You cannot use a va_list twice. As soon as someone call
> > > va_arg() on the SM>> ap all the aps in the calling functions get
> > > invalid. The only thing that SM>> can and must be done is that the
> > > function that did the va_start() must SM>> call va_end.
...
> I missed one in vfwprintf.c.  I needs a va_end(orgap) just like above.
> 
> Also, I've searched all of src and found one additional place that there
> is a va_copy without a va_end.
> 
> contrib/gnu-sort/lib/version-etc.c
> 
> All other uses appear to be properly matched.

Can you please make a new, complete patch?
I'll commit it ASAP.
 
-- 
-- David  (obrien@FreeBSD.org)