Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 Sep 2013 09:07:10 -0400
From:      Sahil Tandon <sahil@tandon.net>
To:        Anton Berezin <tobez@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Bryan Drewery <bdrewery@FreeBSD.org>
Subject:   Re: svn commit: r325805 - head/Mk
Message-ID:  <20130901130709.GA55745@jubz>
In-Reply-To: <20130901105928.GG26604@heechee.tobez.org>
References:  <201308311322.r7VDM2wa076581@svn.freebsd.org> <20130831215840.GA13875@magnus> <20130901105928.GG26604@heechee.tobez.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2013-09-01 at 12:59:28 +0200, Anton Berezin wrote:
[ .. ]
> >   => Attempting to fetch
> >   ftp://ftp.porcupine.org/mirrors/postfix-release/experimental/postfix-2.11-20130825.tar.gz
> >   postfix-2.11-20130825.tar.gz                  100% of 3866 kB  910
> >   kBps
> >   [: -eq: argument expected
> >   => Fetched file size mismatch (expected , actual 3959547)
> >   => Trying next site
> > 
> > This only happens if the distfile does not already exist (and therefore
> > needs to be fetched), and I 'make makesum'.  Apparently, CKSIZE is
> > undefined.  Notably, if I 'make fetch' first, and then 'make makesum',
> > there is no problem.
> 
> I see the same behavior.  So, updating ports is kinda broken at the moment.

Looking at this a bit more, and I believe it happens because the makesum
target calls the fetch target with DISABLE_SIZE=yes, and earlier in
bsd.port.mk, we have:

  .if !defined(DISABLE_SIZE)
  FETCH_BEFORE_ARGS+=     $${CKSIZE:+-S $$CKSIZE}
  .endif

Because CKSIZE is undefined, the following comparison inside the fetch
target does not work as intended:

  if [ $${actual_size} -eq $${CKSIZE} ]; then \

Hope this helps.

-- 
Sahil Tandon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130901130709.GA55745>