Date: Fri, 29 May 2009 22:11:15 +0200 From: Ivan Voras <ivoras@freebsd.org> To: Edward Tomasz Napierala <trasz@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r193041 - head/sys/sys Message-ID: <9bbcef730905291311u5f39708bifbd8af9fad195965@mail.gmail.com> In-Reply-To: <200905291500.n4TF04HM078212@svn.freebsd.org> References: <200905291500.n4TF04HM078212@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2009/5/29 Edward Tomasz Napierala <trasz@freebsd.org>: > =C2=A0 =C2=A0 =C2=A0 =C2=A0u_int =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mnt_f= lag; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* (i) flags shared w= ith user */ > + =C2=A0 =C2=A0 =C2=A0 u_int =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mnt_xflag= ; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* (i) more flags shared = with user */ I have a trivial question, it probably has to do more with style than with technical issues: why not expand this variable to u_int64 instead of introducing another variable? Atomicity of int access on 32-bit platforms could be an answer but judging from what the variable does, I don't see it being very relevant.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9bbcef730905291311u5f39708bifbd8af9fad195965>