Date: Fri, 26 Jul 2002 08:25:27 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: Cyrille Lefevre <cyrille.lefevre@laposte.net> Cc: Ruslan Ermilov <ru@FreeBSD.ORG>, Bruce Evans <bde@zeta.org.au>, Doug Barton <DougB@FreeBSD.ORG>, Mike Barcroft <mike@FreeBSD.ORG>, arch@FreeBSD.ORG Subject: Re: Standardized make options (or no doesn't always mean no) Message-ID: <20020726082527.A69507@FreeBSD.org> In-Reply-To: <20020726135923.GA89959@gits.dyndns.org>; from cyrille.lefevre@laposte.net on Fri, Jul 26, 2002 at 03:59:23PM %2B0200 References: <3D02AB11.F373AB4@FreeBSD.org> <20020609123557.X21758-100000@gamplex.bde.org> <20020725070145.GE56367@sunbay.com> <20020725165940.GF58642@gits.dyndns.org> <20020725170940.GA40574@sunbay.com> <20020726135923.GA89959@gits.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* De: Cyrille Lefevre <cyrille.lefevre@laposte.net> [ Data: 2002-07-26 ] [ Subjecte: Re: Standardized make options (or no doesn't always mean no) ] > On Thu, Jul 25, 2002 at 08:09:40PM +0300, Ruslan Ermilov wrote: > > On Thu, Jul 25, 2002 at 06:59:40PM +0200, Cyrille Lefevre wrote: > > > On Thu, Jul 25, 2002 at 10:01:45AM +0300, Ruslan Ermilov wrote: > [snip] > > > > We'd provide the compatibility knobs that would also trigger a warning > > > > (a .warning to be added to make(1)) that NO_FOO should now be used > > > > instead of NOFOO (or vice versa, if we decide to go that way). > > > > > > .warning isn't needed, let's try w/ .BEGIN :) > > well, il fact, a .warning is needed for the newer knob because > it seems you can't do something like this : Can't you use a double-colon rule to accomplish that? Also, the diff seems reasonable, but you really do want to keep in mind that most places where make(1) substitutes/expands variables, it will be allocating memory. Leaks bad. juli. > - /* use fprintf/exit instead of Parse_Error to terminate immediately */ > - fprintf(stderr, "\"%s\", line %d: %s\n", fname, lineno, errmsg); > + Parse_Error(PARSE_FATAL, "%s", errmsg); > exit(1); This seems like a regression. -- Juli Mallett <jmallett@FreeBSD.org> | FreeBSD: The Power To Serve Will break world for fulltime employment. | finger jmallett@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020726082527.A69507>