From owner-cvs-all@FreeBSD.ORG Thu Nov 20 08:29:24 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66AE816A4D0 for ; Thu, 20 Nov 2003 08:29:24 -0800 (PST) Received: from mail.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id E61EE43FBD for ; Thu, 20 Nov 2003 08:29:21 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 6424 invoked from network); 20 Nov 2003 16:29:21 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 20 Nov 2003 16:29:21 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id hAKGTGFn030468; Thu, 20 Nov 2003 11:29:16 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20031119160312.A69420@root.org> Date: Thu, 20 Nov 2003 11:29:16 -0500 (EST) From: John Baldwin To: Nate Lawson X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/acpica acpi.c acpi_cpu.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Nov 2003 16:29:24 -0000 On 20-Nov-2003 Nate Lawson wrote: > On Wed, 19 Nov 2003, John Baldwin wrote: >> One minor suggestion btw. Could you fix the hw.acpi.cpu.cpu_cx_lowest >> to use the "C1", "C2", and "C3" strings for its user-visible interface >> instead of the direct integer? Setting the value to C2 is a bit more >> intuitive than setting it to 1 to get C2. > > I considered this before, however Cx is really a type, not a given state. > There can be more than 3 sleep states. For instance, the IBM R40 has C1, > C2, C3, and C3 (4 states). An index was the only unique way I could > specify the states. The transition latency is also unique but setting a > state to 182 to get the last C3 state is even worse from a user > perspective. Ah. Maybe rename the sysctl/tunable to indicate that it is an index? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/