From owner-freebsd-ports@freebsd.org Thu May 17 23:18:47 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2BF70EE2FC7 for ; Thu, 17 May 2018 23:18:47 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-ot0-x235.google.com (mail-ot0-x235.google.com [IPv6:2607:f8b0:4003:c0f::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B3F567AF7C for ; Thu, 17 May 2018 23:18:46 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: by mail-ot0-x235.google.com with SMTP id l12-v6so7003994oth.6 for ; Thu, 17 May 2018 16:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sippysoft-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=S/PD9MWZ/8kncYDmXpsJOoRJqU6J2qN+icvYEJQ08rA=; b=yFSipXS5wqrjynlYYC0jO0bLD7i1HubbMOaEaZKbei2qwRlnV3w5PIqcXinf4Yi3zr rjlezrvdj6XJFLpUqkf4Nq0GJjvrXXXe/78B7BbLP5J79F5GptiDohDhMzA8ZHDpw+K1 VtjQYHLPpOZFon5GjJxt1ZhynCHrUWlgV1weAbt6c4DrFAC9pD0vy9VL4pitQzVkR3be qdl9rMiYNP+ZUcHcPSBxfhjcwe8RATxB8OiHo3kiw9nYQX5cFfqEVoEIYL5RfaOXImEY EJa/g97LDRMMEfei7MQLzATP+WOnjikgyd0dQnH/7jrBAdRl5gYZdgl25Gapt0m0fKCy Kbdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=S/PD9MWZ/8kncYDmXpsJOoRJqU6J2qN+icvYEJQ08rA=; b=jOy+eFLYPOOr3ntbdnQ0oJ1VOQ2kMdxrAx+mVF5zhteRnHUybaGJGWEZV76EY5B6XR onbRgv/0W885LO3J1zGHPDvLCLnsvTbETDVVOgDlq96WhrwK3/UwYr1zOJF1DRnpGP4A AjkO2K7euFU+5ozn5kfu4VZDQr30Wd46MJwA23bUGJnIST/CorFL7ToT3duEvUlRzZy6 KtGBb9P8TlQX7r6s3M2Yh8TGZBZ6h//a+3DKFVvOuhB6pw7/IXgYHaZK7nZtENA7CRv4 +T26taOTqsGUSoQJ9HFDENP5A3qNNpDeN9ULBojFljA8b2d5lU8oScCnNtep9YHII5hd 0/Mw== X-Gm-Message-State: ALKqPweSZUpTz+LrHvK0szlA1IV0Kkwoqe7LkRAya4bvnfkLO06MfV4x Js47RFgRN7JV+a9l5fGtfyNlDZ1YES3EA4S72tgHpQ== X-Google-Smtp-Source: AB8JxZri9YXA51Rs/9F3TFJerKk340u5l5lA9AKSqHaFDv9BqLhLdx2b8EbfIhqfFTb/bEX0Q+p/91/+NhipiDaazXg= X-Received: by 2002:a9d:48f1:: with SMTP id a46-v6mr4775293otj.94.1526599122670; Thu, 17 May 2018 16:18:42 -0700 (PDT) MIME-Version: 1.0 Sender: sobomax@sippysoft.com Received: by 10.201.93.67 with HTTP; Thu, 17 May 2018 16:18:42 -0700 (PDT) In-Reply-To: <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> References: <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> From: Maxim Sobolev Date: Thu, 17 May 2018 16:18:42 -0700 X-Google-Sender-Auth: rNVACRIx_xxHJxD0E1X7IVrJkc0 Message-ID: Subject: Re: Practice of "Sponsored by" in commit messages To: "John W. O'Brien" Cc: FreeBSD Ports Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 23:18:47 -0000 John, no, not really, sorry. Work is done, credit is given. The form and amount of this credit is between whoever does the work and whoever is being credited. I don't see why is there any third-party to be involved in governing whether or not this credit is "appropriate", "sufficient" or "all encompassing" for the work in question. This is just a credit, it does not affect the quality of work, nor the license (which is 2-clause BSD) nor the copyright holder. Three things that really matter long-time. So "Sponsored by" it's just the message on the t-shirt, having only meaning to whoever produces the piece and whoever wears it, but nothing in particular to the outside world. IMHO. -Max On Thu, May 17, 2018 at 3:43 PM, John W. O'Brien wrote: > On 2018/05/14 20:14, Maxim Sobolev wrote: > > What's wrong with a current practice. Why is it of any concern to you, > > John? Just curious that is not very clear from your message. It is like > > someone trying to moderate what people in general or some group in > > particular (e.g. freebsd committers) are allowed to put on their > > t-shirts just because you find it offensive or inappropriate. > > I don't find crediting sponsors offensive nor inappropriate. Quite the > contrary. What I find problematic is when multiple people do work, not > all with sponsorship or the same sponsorship, and only one person's > sponsor is mentioned in a way that seems to imply that all the work was > sponsored. > > What I'm proposing is not to end or ban the practice, but to improve and > refine it so that sponsors are credited for what they sponsor and not > for what they don't sponsor. > > Is that clearer? > > > On Mon, May 14, 2018, 4:40 PM John W. O'Brien > > wrote: > > > > Hello FreeBSD Ports, > > > > The Committer's Guide section on Commit Log Messages [0], doesn't > cover > > the use of the "Sponsored by" key word. As a non-committer > contributor, > > it only recently occurred to me to wonder what work that credit is > > intended to represent, and whether some light definition would be > > helpful to reduce ambiguity. > > > > When a committer credits a sponsor of theirs, from which the > contributor > > received no sponsorship, the portrayal feels a little awkward. Does > this > > strike the list as a problem, and if so, how ought it be solved? > > > > To make this concrete, allow me to illustrate the situation. > > > > Alice, working on her own time, prepares and contributes a patch. > Bob, > > who works for Acme Corp, reviews and commits the patch on company > time. > > The commit message includes "Sponsored by: Acme Corp". Alice eagerly > > awaits her check from Acme Corp. Should the commit message have read > > "Sponsored by: Acme Corp (Bob)"? > > > > This could be extensible to multiple sponsorships. If, instead, Alice > > prepares the patch having received a grant to do so from Best Sys > Dev, > > the commit message could state "Sponsored by: Acme Corp (Bob), Best > Sys > > Dev (Alice)". > > > > [0] > > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/ > committers-guide/article.html#commit-log-message > > > > PS: I realize that this issue transcends ports, but it's not clear > where > > I should send this instead, and this list seems like it would have a > > reasonably high concentration of people with a stake in the > discussion. > > > -- > John W. O'Brien > OpenPGP keys: > 0x33C4D64B895DBF3B > >