Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 22 Jan 2017 12:57:04 +0000 (UTC)
From:      "Tobias C. Berner" <tcberner@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org
Subject:   svn commit: r432129 - branches/2017Q1/x11-wm/fluxbox/files
Message-ID:  <201701221257.v0MCv4nl023113@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tcberner
Date: Sun Jan 22 12:57:03 2017
New Revision: 432129
URL: https://svnweb.freebsd.org/changeset/ports/432129

Log:
  MFH: r432090
  
  Fix x11-wm/fluxbox: fails to build with clang 4.0
  
  Import upstream commit
  http://git.fluxbox.org/fluxbox.git/commit/util/fluxbox-remote.cc?id=22866c4d30f5b289c429c5ca88d800200db4fc4f
  for issue
  https://sourceforge.net/p/fluxbox/bugs/1138/
  
  PR:		216176
  Approved by:	portmgr blanket, rakuco (mentor)
  
  Approved by:	ports-secteam (junovitch), rakuco (mentor)

Added:
  branches/2017Q1/x11-wm/fluxbox/files/patch-util_fluxbox-remote.cc
     - copied unchanged from r432090, head/x11-wm/fluxbox/files/patch-util_fluxbox-remote.cc
Modified:
Directory Properties:
  branches/2017Q1/   (props changed)

Copied: branches/2017Q1/x11-wm/fluxbox/files/patch-util_fluxbox-remote.cc (from r432090, head/x11-wm/fluxbox/files/patch-util_fluxbox-remote.cc)
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ branches/2017Q1/x11-wm/fluxbox/files/patch-util_fluxbox-remote.cc	Sun Jan 22 12:57:03 2017	(r432129, copy of r432090, head/x11-wm/fluxbox/files/patch-util_fluxbox-remote.cc)
@@ -0,0 +1,15 @@
+Upstream fix for bogus pointer comparison:
+Issue:  https://sourceforge.net/p/fluxbox/bugs/1138/ 
+Commit: http://git.fluxbox.org/fluxbox.git/commit/util/fluxbox-remote.cc?id=22866c4d30f5b289c429c5ca88d800200db4fc4f
+
+--- util/fluxbox-remote.cc.orig	2015-02-08 10:44:45 UTC
++++ util/fluxbox-remote.cc
+@@ -73,7 +73,7 @@ int main(int argc, char **argv) {
+     if (strcmp(cmd, "result") == 0) {
+         XTextProperty text_prop;
+         if (XGetTextProperty(disp, root, &text_prop, atom_result) != 0
+-            && text_prop.value > 0
++            && text_prop.value != 0
+             && text_prop.nitems > 0) {
+ 
+             printf("%s", text_prop.value);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701221257.v0MCv4nl023113>