From owner-cvs-all@FreeBSD.ORG Wed Aug 18 08:17:16 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 57C9216A4CE; Wed, 18 Aug 2004 08:17:16 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F23A43D3F; Wed, 18 Aug 2004 08:17:15 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i7I8H2Iu003035 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 18 Aug 2004 11:17:03 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i7I8H2ui081509; Wed, 18 Aug 2004 11:17:02 +0300 (EEST) (envelope-from ru) Date: Wed, 18 Aug 2004 11:17:02 +0300 From: Ruslan Ermilov To: Greg Lewis , Hartmut Brandt Message-ID: <20040818081702.GB91053@ip.net.ua> References: <200408180706.i7I763ps032344@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hHWLQfXTYDoKhP50" Content-Disposition: inline In-Reply-To: <200408180706.i7I763ps032344@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/java/jdk14 Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2004 08:17:16 -0000 --hHWLQfXTYDoKhP50 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 18, 2004 at 07:06:03AM +0000, Greg Lewis wrote: > glewis 2004-08-18 07:06:03 UTC >=20 > FreeBSD ports repository >=20 > Modified files: > java/jdk14 Makefile=20 > Log: > . The changes to make in -CURRENT to use MAKEFLAGS make us unable to > override the MAKEFLAGS ARCH value in the main HotSpot Makefile. Fix > this by passing in a blank MAKEFLAGS up front so there is nothing to > (try to) override. > =20 > Submitted by: truckman > Requested by: kris > =20 > Revision Changes Path > 1.79 +2 -1 ports/java/jdk14/Makefile >=20 The fix to make(1) was to pass command-line variables as command-line variables to sub-makes, as required by POSIX. It's still possible to override anything that you want, you just need to know well how MAKEFLAGS works. ;) MAKEFLAGS is an *environment* variable that make(1) reads on startup, and treats its contents as if it was specified on the command line. 1. The contents of this environment variable is then entered as the .MAKEFLAGS *global* variable. 2. Makefile can modify this global as necessary, either by modifying the variable directly (including adding to it, overriding it, or even undefining it with .undef), or thru the special .MAKEFLAGS macro. 3. When make(1) calls another ${MAKE}, it enters the value of its global variable .MAKEFLAGS into the environment of sub-make as the MAKEFLAGS variable. Make sure you have the latest make(1), then run this makefile as ``make all FOO=3Dbar''. Note the difference between .MAKEFLAGS variable and a target. %%% =2Eif make(all) =2EMAKEFLAGS+=3D FOO=3Dfoo # override for submakes only #.MAKEFLAGS: FOO=3Dfoo # override for myself and submakes all: @echo "${.TARGET}'s idea of FOO: ${FOO}" @echo .MAKEFLAGS=3D${.MAKEFLAGS} @cd ${.CURDIR} && ${MAKE} submake =2Eendif =2Eif make(submake) submake: @echo "${.TARGET}'s idea of FOO: ${FOO}" @echo .MAKEFLAGS=3D${.MAKEFLAGS} =2Eendif %%% Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --hHWLQfXTYDoKhP50 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (FreeBSD) iD8DBQFBIxB+qRfpzJluFF4RAhPTAKCLok+++pH+rXWGsJ5qNooSmugGnACffw4A +kuWaMetRbwDsDQcBuOzy6A= =A3v8 -----END PGP SIGNATURE----- --hHWLQfXTYDoKhP50--