Date: Tue, 08 Mar 2016 16:06:59 +0100 From: Pietro Cerutti <gahr@gahr.ch> To: Mathieu Arnold <mat@freebsd.org> Cc: wenheping <wenheping2000@hotmail.com>, Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org Subject: RE: svn commit: r410453 - in head/math/fityk: . files Message-ID: <d90fdb7ea886d2ff2da13739a913a2b1@gahr.ch> In-Reply-To: <E5010340890C09BE8EF68750@ogg.in.absolight.net> References: <BLU168-W101BAF80F561B4B29A45AAAACB20@phx.gbl> <E5010340890C09BE8EF68750@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2016-03-08 14:12, Mathieu Arnold wrote: > +--On 8 mars 2016 16:55:35 +0800 wenheping <wenheping2000@hotmail.com> > wrote: > |> Date: Tue, 8 Mar 2016 08:41:19 +0000 > |> From: danfe@FreeBSD.org > |> To: wenheping2000@hotmail.com > |> CC: ports-committers@freebsd.org; svn-ports-all@freebsd.org; > |> svn-ports-head@freebsd.org Subject: Re: svn commit: r410453 - in > |> head/math/fityk: . files > |> > |> On Tue, Mar 08, 2016 at 04:23:53PM +0800, wenheping wrote: > |> > On Tue, 8 Mar 2016 08:10:10 +0000, danfe@FreeBSD.org wrote: > |> > > On Tue, Mar 08, 2016 at 09:22:54AM +0800, wenheping wrote: > |> > > > I did not find 'not mute installation" is wrong in Porter's > |> > > > Handbook. > |> > > > |> > > It might not be articulated loud enough, but it's pretty obvious > |> > > once you think about it: muted commands won't appear in the > build > |> > > log, which makes it harder to debug and fix any issues. > |> > > > |> > > mkdir's are often muted because they do not have the same "debug > |> > > value" as installation commands, but all > cp/COPYTREE_SHARE/ln/etc. > |> > > commands should not be muted. This is pretty common knowledge > in > |> > > our community, I find it strange that you've never heard of it. > |> > > |> > To me mkdir has the same debug-value as cp > |> > |> That's OK, you might mute or not mute mkdir's at your own > discretion. > |> > |> > and I judge the "common knowledge in our community" by Porter's > |> > Handbook or portlint. > |> > |> Truth is that most valuable pieces of wisdom are scattered across > |> maillist discussions and stuff (FWIW, portlint(1) does warn about > muted > |> INSTALL_foo > | > | I hope "most valuable pieces of wisdom" should go into Handbook or > | portlint, but not only exists in maillist. > > They go there. > > All the examples of > https://www.freebsd.org/doc/en/books/porters-handbook/install.html show > the > commands as *not* being silenced. I'll have a looksie around and add a > note about it. Where "commands" is both INSTALL (and similar) and MKDIR commands, as I can see. On 2016-03-08 14:12, Mathieu Arnold wrote: > +--On 8 mars 2016 16:55:35 +0800 wenheping <wenheping2000@hotmail.com> > wrote: > |> Date: Tue, 8 Mar 2016 08:41:19 +0000 > |> From: danfe@FreeBSD.org > |> > > |> > To me mkdir has the same debug-value as cp > |> > |> That's OK, you might mute or not mute mkdir's at your own > discretion. So, danfe@, would you mind explaining to me on which basis muting MKDIRs is "at one's discretion" while muting INSTALLs is "actually wrong"? Given the evidence pointed at by mat@, either both muting MKDIR and INSTALL commands is at one's discretion, or neither is. -- Pietro Cerutti gahr@gahr.ch PGP Public Key: http://gahr.ch/pgp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d90fdb7ea886d2ff2da13739a913a2b1>