From owner-svn-src-all@freebsd.org Fri Nov 27 12:08:31 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EEE624A6970; Fri, 27 Nov 2020 12:08:31 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CjD1C5pBxz3Fn9; Fri, 27 Nov 2020 12:08:31 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 762868D4A166; Fri, 27 Nov 2020 12:08:23 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id EBBA2E708BC; Fri, 27 Nov 2020 12:08:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id kVRnwQMz9MMy; Fri, 27 Nov 2020 12:08:21 +0000 (UTC) Received: from [127.0.0.1] (unknown [IPv6:fde9:577b:c1a9:4902:a426:5154:d8c0:5efb]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 2EBF1E707C0; Fri, 27 Nov 2020 12:08:20 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Alan Somers" Cc: src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r368045 - in head: . etc/mtree rescue/rescue sbin sbin/ping sbin/ping/tests sbin/ping6 sbin/ping6/tests tools/build/mk Date: Fri, 27 Nov 2020 12:08:19 +0000 X-Mailer: MailMate (2.0BETAr6151) Message-ID: <1E846E83-998A-4ACC-9491-D0411899C1A7@lists.zabbadoz.net> In-Reply-To: References: <202011260429.0AQ4TV2B023801@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4CjD1C5pBxz3Fn9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2020 12:08:32 -0000 On 26 Nov 2020, at 18:51, Alan Somers wrote: > On Thu, Nov 26, 2020 at 2:16 AM Bjoern A. Zeeb < > bzeeb-lists@lists.zabbadoz.net> wrote: > >> On 26 Nov 2020, at 4:29, Alan Somers wrote: >> >>> Author: asomers >>> Date: Thu Nov 26 04:29:30 2020 >>> New Revision: 368045 >>> URL: https://svnweb.freebsd.org/changeset/base/368045 >>> >>> Log: >>> Merge ping6 to ping >>> >>> There is now a single ping binary, which chooses to use ICMP or >>> ICMPv4 >>> based on the -4 and -6 options, and the format of the address. >>> >>> Submitted by: Ján Sučan >>> Sponsored by: Google LLC (Google Summer of Code 2019) >>> MFC after: Never >>> Differential Revision: https://reviews.freebsd.org/D21377 >> >> I don’t have IPv4 anymore. >> I don’t see any WITHOUT_INET or -DINET checks. >> How can I compile INET out now? >> > > I don't see any such checks before, either. Was it ever possible to > exclude ping by building WITHOUT_INET? No, for various reasons including startup scripts relying on it etc. I think no one ever bothered to fully find it all. But it was possible to just ditch the binary (not installing it into custom images, or rm -f it post-install along with other things). Now it’s a “dual-stack handling” binary and those we’ve tried with a lot of care to make sure they grow compiling out both ways as you cannot throw away the binary anymore. I don’t know how hard it is to do this now. I’ll be happy to have a look and help if it’s not a 5 minute job for you knowing the code and split up. Would we just have to handle main.c with #ifdefs and the old ping[4] files from the Makefile or is ping6 also using shared code from the former ping[4]? /bz