Date: Fri, 11 Jan 2019 10:41:44 -0800 From: Devin Teske <dteske@FreeBSD.org> To: rgrimes@freebsd.org Cc: Devin Teske <dteske@FreeBSD.org>, Warner Losh <imp@bsdimp.com>, Lars Engels <lme@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r342945 - in head: tools/build/mk usr.sbin/bluetooth usr.sbin/bluetooth/bluetooth-config Message-ID: <A5C8049C-DB95-4EBC-965E-A4DD399EF020@FreeBSD.org> In-Reply-To: <201901111836.x0BIaGVJ022426@pdx.rh.CN85.dnsmgr.net> References: <201901111836.x0BIaGVJ022426@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 11, 2019, at 10:36 AM, Rodney W. Grimes = <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: >=20 > [ Charset UTF-8 unsupported, converting... ] >> On Fri, Jan 11, 2019 at 10:10 AM Rodney W. Grimes < >> freebsd@pdx.rh.cn85.dnsmgr.net> wrote: >>=20 >>>> On Fri, Jan 11, 2019 at 08:04:33AM -0800, Rodney W. Grimes wrote: >>>>> The style of this .sh does not match the normal style of >>>>> such things in base, especially with respect to long lines >>>>> and indentation. >>>>=20 >>>> Do we have a style guide for shell scripts in base? How should >>>> indentation look like? >>>=20 >>> Not that I can locate, but I can state that almost all >>> of the base code uses tab indenting and limited to 80 >>> column widths, independent of c, sh, make, etc. >>>=20 >>=20 >> We have a style.Makefile, style, style.mdoc and style.lua man pages. = Maybe >> it's time for style.sh, eh? >=20 > Yes please! >=20 If we can agree to be professional and collegial, ... I'll start with chapters from the Style section of my book: = https://freebsdfrau.gitbooks.io/serious-shell-programming/content/style/aw= k.html = <https://freebsdfrau.gitbooks.io/serious-shell-programming/content/style/a= wk.html> --=20 Devin=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A5C8049C-DB95-4EBC-965E-A4DD399EF020>