Date: Fri, 20 Jul 2018 07:16:29 +0000 (UTC) From: Xin LI <delphij@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r336541 - head/lib/libcrypt Message-ID: <201807200716.w6K7GT16079640@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: delphij Date: Fri Jul 20 07:16:28 2018 New Revision: 336541 URL: https://svnweb.freebsd.org/changeset/base/336541 Log: libcrypt: There is no need to clear message digest context after they are finialized after r336539, so do not do it. Submitted by: David CARLIER <devnexen gmail com> MFC after: 1 month (after r336539) Differential Revision: https://reviews.freebsd.org/D16059 Modified: head/lib/libcrypt/crypt-sha256.c head/lib/libcrypt/crypt-sha512.c Modified: head/lib/libcrypt/crypt-sha256.c ============================================================================== --- head/lib/libcrypt/crypt-sha256.c Fri Jul 20 07:07:27 2018 (r336540) +++ head/lib/libcrypt/crypt-sha256.c Fri Jul 20 07:16:28 2018 (r336541) @@ -239,8 +239,6 @@ crypt_sha256(const char *key, const char *salt, char * memset(temp_result, '\0', sizeof(temp_result)); memset(p_bytes, '\0', key_len); memset(s_bytes, '\0', salt_len); - memset(&ctx, '\0', sizeof(ctx)); - memset(&alt_ctx, '\0', sizeof(alt_ctx)); return (0); } Modified: head/lib/libcrypt/crypt-sha512.c ============================================================================== --- head/lib/libcrypt/crypt-sha512.c Fri Jul 20 07:07:27 2018 (r336540) +++ head/lib/libcrypt/crypt-sha512.c Fri Jul 20 07:16:28 2018 (r336541) @@ -251,8 +251,6 @@ crypt_sha512(const char *key, const char *salt, char * memset(temp_result, '\0', sizeof(temp_result)); memset(p_bytes, '\0', key_len); memset(s_bytes, '\0', salt_len); - memset(&ctx, '\0', sizeof(ctx)); - memset(&alt_ctx, '\0', sizeof(alt_ctx)); return (0); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807200716.w6K7GT16079640>