From owner-svn-src-all@freebsd.org Wed Oct 16 13:58:22 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 407091659D2; Wed, 16 Oct 2019 13:58:22 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46tYmG0q3gz3HsG; Wed, 16 Oct 2019 13:58:21 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 64B782602CD; Wed, 16 Oct 2019 15:58:19 +0200 (CEST) Subject: Re: svn commit: r353642 - head/sys/dev/usb/controller To: Emmanuel Vadot , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201910161353.x9GDrrUq044752@repo.freebsd.org> From: Hans Petter Selasky Message-ID: <58b56930-36d4-8e09-366e-a425c959b408@selasky.org> Date: Wed, 16 Oct 2019 15:56:16 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <201910161353.x9GDrrUq044752@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46tYmG0q3gz3HsG X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.991,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Oct 2019 13:58:22 -0000 On 2019-10-16 15:53, Emmanuel Vadot wrote: > Author: manu > Date: Wed Oct 16 13:53:53 2019 > New Revision: 353642 > URL: https://svnweb.freebsd.org/changeset/base/353642 > > Log: > dwc3: Use a pair of ()'s around arguments for some macros > > Reported by: hselasky > MFC after: 1 week > X-MFC-With: r353533 > > Modified: > head/sys/dev/usb/controller/dwc3.h > > Modified: head/sys/dev/usb/controller/dwc3.h > ============================================================================== > --- head/sys/dev/usb/controller/dwc3.h Wed Oct 16 13:30:28 2019 (r353641) > +++ head/sys/dev/usb/controller/dwc3.h Wed Oct 16 13:53:53 2019 (r353642) > @@ -92,8 +92,8 @@ > #define DWC3_GUSB3PIPECTL0_PHYSOFTRST (1 << 31) > #define DWC3_GUSB3PIPECTL0_DELAYP1TRANS (1 << 18) > > -#define DWC3_GTXFIFOSIZ(x) (0xc300 + 0x4 * x) > -#define DWC3_GRXFIFOSIZ(x) (0xc380 + 0x4 * x) > +#define DWC3_GTXFIFOSIZ(x) (0xc300 + 0x4 * (x)) > +#define DWC3_GRXFIFOSIZ(x) (0xc380 + 0x4 * (x)) > #define DWC3_GEVNTADRLO0 0xc400 > #define DWC3_GEVNTADRHI0 0xc404 > #define DWC3_GEVNTSIZ0 0xc408 > One more: 86 #define DWC3_GUSB2PHYCFG0_PHYSEL(x) ((x >> 7) & 0x1) /* 0 = USB2.0, 1 = USB1.1 */ --HPS