From owner-freebsd-rc@freebsd.org Wed Sep 23 16:44:07 2015 Return-Path: Delivered-To: freebsd-rc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 07167A0698A; Wed, 23 Sep 2015 16:44:07 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-yk0-f179.google.com (mail-yk0-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C14231322; Wed, 23 Sep 2015 16:44:06 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by ykft14 with SMTP id t14so47468019ykf.0; Wed, 23 Sep 2015 09:44:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=EaCfrisNwx8ne2wQ3bQA1DR0vDDUh4FggmLurriqsAo=; b=TD5sYV5SI2YkVAfCfgmKw+EmeOLY13JEElaIIlOxCjTK6pcoM3e1n/KVd49uDvkh9k unIUeu6snYEfjl+W7tjVVFWSCeMG7/yKwkJtlvRzbaFfT3hw7aYieQRJ9Tku0qkhwafB gH8Ve7qNV5E7FmagOZkPLdn1AKIYn4qI+j4FcIO7gxtaw8g+I19Jr6+kqyoJFV9Xl4OI Eumq+9Hh9URTSeV5R+oTjI/xGk6ZUfZqHZxdOyCOYBZTa4/rXnwxptye46wdKHQ9eGUm j73avHSEMjpd42YyppVExzuoSK2p71qdVouicd+lUEI90hIYpleNghtbqbmIglaH0qF+ RYpg== X-Received: by 10.129.91.196 with SMTP id p187mr17747868ywb.106.1443026645412; Wed, 23 Sep 2015 09:44:05 -0700 (PDT) Received: from mail-yk0-f176.google.com (mail-yk0-f176.google.com. [209.85.160.176]) by smtp.gmail.com with ESMTPSA id e68sm4840033ywd.34.2015.09.23.09.44.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Sep 2015 09:44:05 -0700 (PDT) Received: by ykdz138 with SMTP id z138so47318628ykd.2; Wed, 23 Sep 2015 09:44:04 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.13.209.69 with SMTP id t66mr7861076ywd.95.1443026644974; Wed, 23 Sep 2015 09:44:04 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.37.60.198 with HTTP; Wed, 23 Sep 2015 09:44:04 -0700 (PDT) In-Reply-To: <5602CDBC.7080906@FreeBSD.org> References: <5602B922.20703@FreeBSD.org> <5602CDBC.7080906@FreeBSD.org> Date: Wed, 23 Sep 2015 09:44:04 -0700 Message-ID: Subject: Re: dumpdev in loader.conf vs rc.d/dumpon From: Conrad Meyer To: Andriy Gapon Cc: FreeBSD Current , freebsd-rc@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2015 16:44:07 -0000 On Wed, Sep 23, 2015 at 9:05 AM, Andriy Gapon wrote: > On 23/09/2015 18:59, Conrad Meyer wrote: >> On Wed, Sep 23, 2015 at 7:37 AM, Andriy Gapon wrote: > Because that's how I read the code in sys/geom/geom_dev.c. Especially > init_dumpdev() - I believe that devtoname() returns a device name without '/dev/'. I don't think that's the primary use of the variable. >> I don't see etc/rc.d/dumpon prepending /dev to anything. > > Right, that's why I posted my message (bug report). I think the use of the variable "dumpdev" in GEOM probably could/should be dropped. Alternatively (perhaps it is a mechanism for collecting crash dumps before init / /etc/rc start?) the GEOM dumpdev code could skip over a "/dev/" prefix when comparing against devname(), so that the GEOM use of the variable matches the etc/rc.d/dumpon use of the variable. Best, Conrad