From owner-svn-src-head@freebsd.org Thu Feb 23 15:30:23 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15130CEBD02; Thu, 23 Feb 2017 15:30:23 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D650ECEA; Thu, 23 Feb 2017 15:30:22 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v1NFUMoo024029; Thu, 23 Feb 2017 15:30:22 GMT (envelope-from pfg@FreeBSD.org) Received: (from pfg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v1NFULwx024028; Thu, 23 Feb 2017 15:30:21 GMT (envelope-from pfg@FreeBSD.org) Message-Id: <201702231530.v1NFULwx024028@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: pfg set sender to pfg@FreeBSD.org using -f From: "Pedro F. Giffuni" Date: Thu, 23 Feb 2017 15:30:21 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r314142 - head/sys/dev/ce X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 15:30:23 -0000 Author: pfg Date: Thu Feb 23 15:30:21 2017 New Revision: 314142 URL: https://svnweb.freebsd.org/changeset/base/314142 Log: dev/ce: double assignment. The code is not operational right now so just comment away an obviously useless assignment. Fix some typos while here. Found with: coccinelle (da.cocci) Modified: head/sys/dev/ce/ceddk.c Modified: head/sys/dev/ce/ceddk.c ============================================================================== --- head/sys/dev/ce/ceddk.c Thu Feb 23 15:10:46 2017 (r314141) +++ head/sys/dev/ce/ceddk.c Thu Feb 23 15:30:21 2017 (r314142) @@ -621,10 +621,10 @@ void ce_stop_chan (ce_chan_t *c) TAU32_UserRequest *req; CE_DEQUEUE (b->cr.queue, req); - /* XXXRIK: This function should be for comleteness, but for now I - * don't use it. So I just start to write and didn't finished it yet. - * It and it is VERY BUGGY!!! Do not use it. If you really - * need it ask me to fix it or rewrite it by your self. + /* XXXRIK: This function should be for completeness, but for now I + * don't use it. I just started to write and haven't finished it yet. + * It is VERY BUGGY!!! Do not use it. If you really need + * it ask me to fix it or rewrite it by yourself. * Note: most buggy part of it in ce_on_config_stop! */ if (!req) { @@ -632,8 +632,8 @@ void ce_stop_chan (ce_chan_t *c) "UserRequest (%s:%d)\n", __FUNCTION__, __LINE__)); return; } - req->Command = TAU32_Configure_Commit | - TAU32_Tx_Stop | TAU32_Rx_Stop; +// req->Command = TAU32_Configure_Commit | +// TAU32_Tx_Stop | TAU32_Rx_Stop; req->Command = 0; req->Io.ChannelNumber = c->num; req->pCallback = ce_on_config_stop;