Date: Tue, 25 Aug 2015 18:47:18 +0000 From: bugzilla-noreply@freebsd.org To: ruby@FreeBSD.org Subject: maintainer-feedback requested: [Bug 202660] Fix lang/ruby21 installed header to fix signed shift warnings for other ports (e.g. devel/rubygem-thrift) Message-ID: <bug-202660-21402-AIkonU3gHD@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-202660-21402@https.bugs.freebsd.org/bugzilla/> References: <bug-202660-21402@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Dimitry Andric <dim@FreeBSD.org> has reassigned Bugzilla Automation <bugzilla@FreeBSD.org>'s request for maintainer-feedback to ruby@FreeBSD.or= g: Bug 202660: Fix lang/ruby21 installed header to fix signed shift warnings f= or other ports (e.g. devel/rubygem-thrift) https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202660 --- Description --- Created attachment 160356 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D160356&action= =3Dedit Fix signed left-shifting in lang/ruby21's public ruby.h During the exp-run in bug 201377, it was found that devel/rubygem-thrift gi= ves errors with a recent clang 3.7.0 snapshot: http://package18.nyi.freebsd.org/data/headi386PR201377-default/2015-08-20_1= 5h42 m20s/logs/errors/rubygem-thrift-0.9.1,1.log This is because it includes ruby.h from the lang/ruby21 port, which uses th= is macro: #define INT2FIX(i) ((VALUE)(((SIGNED_VALUE)(i))<<1 | FIXNUM_FLAG)) Unfortunately, left-shifting negative 'i' values is undefined behavior, so clang warns about this. I changed the macro to: #define INT2FIX(i) ((VALUE)(((VALUE)(i))<<1 | FIXNUM_FLAG)) which avoids the undefined behavior by casting to VALUE (which is unsigned) first. I ran all ruby21 tests before and after this fix, and I got "1 failures, 4 errors" in both cases, so no regressions. However, since this is a public ruby header, I can imagine that this is a change that makes some people nervous. So if ruby maintainers prefer to fix this in the devel/rubygem-thrift port instead, for example by squelching the warning, please let me know.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-202660-21402-AIkonU3gHD>