Date: Fri, 05 Oct 2012 01:13:20 +0200 From: nemysis <nemysis@gmx.ch> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/172342: [PATCH] graphics/eos-movrec: Makefile changed, OptionsNG, take maintainership Message-ID: <20121004231326.47B3F106566B@hub.freebsd.org> Resent-Message-ID: <201210042320.q94NK7D2032888@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 172342
>Category: ports
>Synopsis: [PATCH] graphics/eos-movrec: Makefile changed, OptionsNG, take maintainership
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Oct 04 23:20:07 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: nemysis
>Release: FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC
>Description:
- Take maintainership
- Used more correct
+PORTVERSION= 0.3.1
+DISTNAME= ${PORTNAME}-${DISTVERSION}_beta-src
- Changed COMMENT
+COMMENT= Program to capture short movies with Canon DSLR camera
- Added EXTRACT_DEPENDS
+EXTRACT_DEPENDS=convert:${PORTSDIR}/graphics/ImageMagick
- Not needed, WRKSRC is default
-WRKSRC= ${WRKDIR}/${PORTNAME}-${DISTVERSION}
-DISTVERSIONSUFFIX= -src
-PORTREVISION= 1
- Added DESKTOP_ENTRIES
+DESKTOP_ENTRIES
- Added post-extract and post-install to have png for DESKTOP_ENTRIES
+post-extract:
+ @(cd ${WRKSRC} && convert eos-movrec2.ico eos-movrec2.png)
+post-install:
+ ${INSTALL_DATA} ${WRKSRC}/${PORTNAME}2-6.png ${PREFIX}/share/pixmaps/${PORTNAME}.png
Generated and tested manually, tested with port test and with RedPorts (all RELEASES, CLANG), sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:
portlint -A
WARN: Makefile: possible use of absolute pathname "/_/}".
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in gphoto2.2 unless it is really necessary.
0 fatal errors and 5 warnings found.
WARN: Makefile: possible use of absolute pathname "/_/}". because is used
${PORTNAME:S/-/_/}"
WARN: Makefile: using hyphen in PORTNAME. because is used as before
PORTNAME= eos-movrec
port test: clean
Build log RedPorts
https://redports.org/buildarchive/20121003211136-18414/
>Fix:
--- eos-movrec-0.3.1_2.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/graphics/eos-movrec/Makefile ./Makefile
--- /usr/ports/graphics/eos-movrec/Makefile 2012-06-06 08:43:50.000000000 +0200
+++ ./Makefile 2012-10-03 23:10:35.000000000 +0200
@@ -6,29 +6,41 @@
#
PORTNAME= eos-movrec
-DISTVERSION= 0.3.1_beta
-PORTREVISION= 1
+PORTVERSION= 0.3.1
+PORTREVISION= 2
CATEGORIES= graphics
-MASTER_SITES= SF/${PORTNAME}/${PORTNAME}/0.3_beta
+MASTER_SITES= SF/${PORTNAME}/${PORTNAME}/0.3_beta/
+DISTNAME= ${PORTNAME}-${DISTVERSION}_beta-src
-MAINTAINER= ports@FreeBSD.org
-COMMENT= A program to capture short movies with Canon DSLR camera
+MAINTAINER= nemysis@gmx.ch
+COMMENT= Program to capture short movies with Canon DSLR camera
LICENSE= GPLv2
LIB_DEPENDS= gphoto2.2:${PORTSDIR}/graphics/libgphoto2
+EXTRACT_DEPENDS=convert:${PORTSDIR}/graphics/ImageMagick
-USE_ZIP= yes
+WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}_beta
+
+USE_BZIP2= yes
USE_CMAKE= yes
+CMAKE_VERBOSE= yes
+
USE_QT4= qmake_build moc_build rcc_build uic_build gui
-WRKSRC= ${WRKDIR}/${PORTNAME}-${DISTVERSION}
-DISTVERSIONSUFFIX= -src
-PORTREVISION= 1
+PLIST_FILES= bin/eos_movrec \
+ share/pixmaps/${PORTNAME}.png
-PLIST_FILES= bin/eos_movrec
+DESKTOP_ENTRIES="EOS Camera Movie Record" "${COMMENT}" "${PORTNAME}" \
+ "${PORTNAME:S/-/_/}" "Application;Graphics;" ${FALSE}
+
+post-extract:
+ @(cd ${WRKSRC} && convert eos-movrec2.ico eos-movrec2.png)
post-patch:
@${REINPLACE_CMD} -e 's,GLIBC,${OPSYS},' ${WRKSRC}/os_api.h
+post-install:
+ ${INSTALL_DATA} ${WRKSRC}/${PORTNAME}2-6.png ${PREFIX}/share/pixmaps/${PORTNAME}.png
+
.include <bsd.port.mk>
diff -ruN --exclude=CVS /usr/ports/graphics/eos-movrec/distinfo ./distinfo
--- /usr/ports/graphics/eos-movrec/distinfo 2011-08-15 17:36:45.000000000 +0200
+++ ./distinfo 2012-10-03 21:54:48.000000000 +0200
@@ -1,2 +1,2 @@
-SHA256 (eos-movrec-0.3.1_beta-src.zip) = 25897e7d173d6baa0cfa94a8e0ff5f3decf809d2644ddf2a492677c068efc0c3
-SIZE (eos-movrec-0.3.1_beta-src.zip) = 5183470
+SHA256 (eos-movrec-0.3.1_beta-src.tar.bz2) = 044cf8b6428d66d6d03c3df53103f985e5b669cad3c8f78a94f9ef308259deea
+SIZE (eos-movrec-0.3.1_beta-src.tar.bz2) = 3955037
--- eos-movrec-0.3.1_2.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121004231326.47B3F106566B>