Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Apr 2019 09:27:25 -0700
From:      Greg Lewis <glewis@eyesbeyond.com>
To:        Mathieu Arnold <mat@freebsd.org>
Cc:        Greg Lewis <glewis@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r499685 - head/java/openjdk8
Message-ID:  <20190423162725.GA57876@misty.eyesbeyond.com>
In-Reply-To: <20190423074622.puxd7fibzxx3xvmr@atuin.in.mat.cc>
References:  <201904222052.x3MKqqVH050067@repo.freebsd.org> <20190423074622.puxd7fibzxx3xvmr@atuin.in.mat.cc>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 23, 2019 at 09:46:22AM +0200, Mathieu Arnold wrote:
> On Mon, Apr 22, 2019 at 08:52:52PM +0000, Greg Lewis wrote:
> > Author: glewis
> > Date: Mon Apr 22 20:52:52 2019
> > New Revision: 499685
> > URL: https://svnweb.freebsd.org/changeset/ports/499685
> > 
> > Log:
> >   Always depend on fontconfig
> >   
> >   PR:		203862
> >   Submitted by:	Dominik Lisiak <dominik.lisiak@bemsoft.pl>
> 
> You need to bump PORTREVISION when you change the runtime dependencies.

I didn't bump it since this is a build fix.  I.e., we fail the configure
step without the dependency.  If that still requires a PORTREVISION bump
then I think the porters handbook could use with some clarification on
the topic.

> > Modified:
> >   head/java/openjdk8/Makefile
> > 
> > Modified: head/java/openjdk8/Makefile
> > ==============================================================================
> > --- head/java/openjdk8/Makefile	Mon Apr 22 20:42:39 2019	(r499684)
> > +++ head/java/openjdk8/Makefile	Mon Apr 22 20:52:52 2019	(r499685)
> > @@ -18,7 +18,8 @@ BUILD_DEPENDS=	zip:archivers/zip \
> >  		autoconf>0:devel/autoconf \
> >  		-/include/cups/cups.h:print/cups \
> >  		bash:shells/bash
> > -LIB_DEPENDS=	libfreetype.so:print/freetype2 \
> > +LIB_DEPENDS=	libfontconfig.so:x11-fonts/fontconfig \
> > +		libfreetype.so:print/freetype2 \
> >  		libinotify.so:devel/libinotify
> >  RUN_DEPENDS=	javavm:java/javavmwrapper \
> >  		dejavu>0:x11-fonts/dejavu
> > @@ -105,8 +106,7 @@ X11_CONFIGURE_OFF=	--disable-headful
> >  X11_CONFIGURE_ON=	--with-giflib=system \
> >  			--x-includes=-/include \
> >  			--x-libraries=-/lib
> > -X11_LIB_DEPENDS=	libgif.so:graphics/giflib \
> > -			libfontconfig.so:x11-fonts/fontconfig
> > +X11_LIB_DEPENDS=	libgif.so:graphics/giflib
> >  X11_MAKE_ENV_OFF=	BUILD_HEADLESS_ONLY=1 \
> >  			MAKEFLAGS=X_CFLAGS="-I-/include"
> >  X11_MAKE_ENV_ON=	MAKEFLAGS=""



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190423162725.GA57876>