Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Apr 2019 15:09:26 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r346237 - stable/12/sys/dev/nvme
Message-ID:  <201904151509.x3FF9Qgc095517@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Mon Apr 15 15:09:25 2019
New Revision: 346237
URL: https://svnweb.freebsd.org/changeset/base/346237

Log:
  MFC r344736 (by imp): Add ABORTED_BY_REQUEST to the list of things we look
  at DNR bit and tell why to comment (code already does this)

Modified:
  stable/12/sys/dev/nvme/nvme_qpair.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/nvme/nvme_qpair.c
==============================================================================
--- stable/12/sys/dev/nvme/nvme_qpair.c	Mon Apr 15 15:02:18 2019	(r346236)
+++ stable/12/sys/dev/nvme/nvme_qpair.c	Mon Apr 15 15:09:25 2019	(r346237)
@@ -331,7 +331,8 @@ nvme_completion_is_retry(const struct nvme_completion 
 	 * TODO: spec is not clear how commands that are aborted due
 	 *  to TLER will be marked.  So for now, it seems
 	 *  NAMESPACE_NOT_READY is the only case where we should
-	 *  look at the DNR bit.
+	 *  look at the DNR bit. Requests failed with ABORTED_BY_REQUEST
+	 *  set the DNR bit correctly since the driver controls that.
 	 */
 	switch (sct) {
 	case NVME_SCT_GENERIC:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904151509.x3FF9Qgc095517>