From owner-cvs-src@FreeBSD.ORG Tue May 11 11:16:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6BDD616A4CE; Tue, 11 May 2004 11:16:00 -0700 (PDT) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B40043D1D; Tue, 11 May 2004 11:15:55 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.12.11/8.12.10) with ESMTP id i4BIFtwp013577; Tue, 11 May 2004 11:15:55 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.11/8.12.11/Submit) id i4BIFsYa013574; Tue, 11 May 2004 11:15:54 -0700 (PDT) (envelope-from obrien) Date: Tue, 11 May 2004 11:15:54 -0700 From: "David O'Brien" To: Nate Lawson Message-ID: <20040511181554.GA13486@dragon.nuxi.com> References: <20040510115040.0C9B516A53A@hub.freebsd.org> <20040511100208.C75906@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040511100208.C75906@root.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: Maxime Henrion cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/led led.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2004 18:16:00 -0000 On Tue, May 11, 2004 at 10:02:59AM -0700, Nate Lawson wrote: > On Mon, 10 May 2004, Maxime Henrion wrote: > > Modified files: > > sys/dev/led led.h > > Log: > > - Remove the __FBSDID and put the $FreeBSD$ tag in the comment above, > > so that including this file more than once works. .. > Do we even want __FBSDID in .h files? It doesn't seem to make sense since > it's not a compilation unit (i.e. no linkage). It actually does make sense, as a header's contents does wind up in a .o eventually :-) And header contents can be the cause of problems as much as a .c file. There is no problem having multiple __FBSDID in either a.out or ELF objects. That said, its not something we have agreement for [that I know of]. -- -- David (obrien@FreeBSD.org)