From owner-cvs-src@FreeBSD.ORG  Mon May 30 11:14:23 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.ORG
Delivered-To: cvs-src@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5EF5D16A41C;
	Mon, 30 May 2005 11:14:23 +0000 (GMT)
	(envelope-from sobomax@portaone.com)
Received: from www.portaone.com (support.portaone.com [195.70.151.35])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C9E6343D1F;
	Mon, 30 May 2005 11:14:20 +0000 (GMT)
	(envelope-from sobomax@portaone.com)
Received: from [192.168.0.95] (2-zyx-piter-f0285.r5.ll.kw.ua [195.140.246.50])
	(authenticated bits=0)
	by www.portaone.com (8.12.11/8.12.11) with ESMTP id j4UBEHrt040248
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 30 May 2005 13:14:18 +0200 (CEST)
	(envelope-from sobomax@portaone.com)
Message-ID: <429AF57A.5060902@portaone.com>
Date: Mon, 30 May 2005 14:14:02 +0300
From: Maxim Sobolev <sobomax@portaone.com>
Organization: Porta Software Ltd
User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ruslan Ermilov <ru@FreeBSD.ORG>
References: <200505292105.j4TL5w32038570@repoman.freebsd.org>
	<20050530104131.GB54585@ip.net.ua>
In-Reply-To: <20050530104131.GB54585@ip.net.ua>
Content-Type: text/plain; charset=KOI8-U; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV 0.83/899/Mon May 30 08:57:01 2005 on www.portaone.com
X-Virus-Status: Clean
Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/lib/libstand Makefile
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Maxim.Sobolev@portaone.com
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 May 2005 11:14:23 -0000

Ruslan Ermilov wrote:
> Hi,
> 
> On Sun, May 29, 2005 at 09:05:58PM +0000, Maxim Sobolev wrote:
> 
>>sobomax     2005-05-29 21:05:58 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    lib/libstand         Makefile 
>>  Log:
>>  Add missed ${.CURDIR}/../../contrib/bzip2 into include search path, otherwise
>>  old version of bzlib.h can be picked up from the /usr/include.
>>  
>>  Revision  Changes    Path
>>  1.51      +1 -1      src/lib/libstand/Makefile
>>
> 
> Changes like this, while harmless, unnecessarily pollute makefiles.
> During buildworld we first install new headers then build new
> libraries then the rest.  When doing standalone compiles, the same
> procedure should generally be followed.  (Otherwise, you'd end up
> changing every utility's makefile that uses libstand to add this
> -I to CFLAGS.)

This is incorrect assertion since libstand hides implementation details, 
so that it is not necessary to include bzlib.h into code which uses 
libstand.

> I have only problem with the above change: it has a wrong attribution
> in the commit log.  The correct commit log would be: "aid in lazy
> standalone builds by always picking up a fresh copy of bzlib.h from
> sources".

-Maxim