Date: Sat, 19 Sep 2015 18:56:55 +0100 From: Bruce Simpson <bms@fastmail.net> To: Ian Lepore <ian@freebsd.org> Cc: George Neville-Neil <gnn@neville-neil.com>, Hans Petter Selasky <hps@selasky.org>, David Chisnall <theraven@FreeBSD.org>, Gleb Smirnoff <glebius@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys Message-ID: <55FDA1E7.8050007@fastmail.net> In-Reply-To: <1442684369.1224.179.camel@freebsd.org> References: <201509141052.t8EAqRWf008293@repo.freebsd.org> <20150916220559.GS1023@FreeBSD.org> <55FA69BD.10507@selasky.org> <0952027A-5276-487D-99B8-74747B0EEF5D@FreeBSD.org> <55FD23C5.5010008@selasky.org> <64D8263B-1F5D-40E5-994C-479C39B69DC9@neville-neil.com> <1442684369.1224.179.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ian, To paraphrase what I said privately to the various dramatis personae in January: Changes like this need to be reviewed before they go in. As timing is central to the entire OS, change review has to be meticulous, on par with the virtual memory management. We have a VM tsar; we do not have a timing tsar. On 19/09/15 18:39, Ian Lepore wrote: > I'm afraid this message can be interpetted as "reviews are now mandatory > for a 'core component of the system' (whatever that means)". If so, > this would be a Big Change from the last thing I heard about code > reviews, which was basically: as much as some people would like it to be > so, they are not mandatory. ... > a definition as meaningless and vague as[.] I don't believe for one moment that George is advocating for mandatory reviews. But common sense should apply, _as timing is central to the entire OS_. It touches absolutely everything. Hell, I wouldn't feel comfortable checking anything in to e.g. timecounters without at least running it by phk first. So, +1 from me for backout until the change can be reviewed. But to be fair to all involved, perhaps Hans should set out a timeline for how he wants to proceed, subject to the jitter inherent to an all-volunteer project. thanks Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55FDA1E7.8050007>