From owner-svn-src-all@freebsd.org Sat Sep 19 17:57:05 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F100A05CEB for ; Sat, 19 Sep 2015 17:57:05 +0000 (UTC) (envelope-from bms@fastmail.net) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 67A941F19 for ; Sat, 19 Sep 2015 17:57:04 +0000 (UTC) (envelope-from bms@fastmail.net) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id BB43120B7A for ; Sat, 19 Sep 2015 13:56:57 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute3.internal (MEProxy); Sat, 19 Sep 2015 13:56:57 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.net; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=J4EqEUvixKA5i7iK4ePIKFLSws8=; b=eQBKtO dZZi/aX31jU/rMAo2BE/HY6MQC3CqVO/dG79tmrMd7Y/5m09LmUv2ZZ8p2lOe1tG sjo3ZeeM3SXuQvZMWPc9ymPFN5caed1+M/JGAJWb7ZLVVaVC64o65tJEq5uUbkgd AFc0o+PdqHfh8cGHW6StzPeqt4EnAX13LRmeo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=J4EqEUvixKA5i7i K4ePIKFLSws8=; b=l5n13SN6fUKaO1+gZvcsRnGOA86+z+K2P54Ega4M2e43yRW O0ZrHqxZhmQG5V9FG2mm+RhV0Ub92FYs3gu2WE0c3XHdh5rANKIaD+SIjE3dJopG RXwhFyna957yPnc30uD5JjK61vk/GzJ6hC3J+wkHn047FyXxIikFMQoJwwRk= X-Sasl-enc: fJUcqPAf1xE9njuvQmJTN7drx+50j5qv0YW2LaczbokA 1442685417 Received: from pion.local (host81-139-223-71.in-addr.btopenworld.com [81.139.223.71]) by mail.messagingengine.com (Postfix) with ESMTPA id 55956C00014; Sat, 19 Sep 2015 13:56:56 -0400 (EDT) Subject: Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys To: Ian Lepore References: <201509141052.t8EAqRWf008293@repo.freebsd.org> <20150916220559.GS1023@FreeBSD.org> <55FA69BD.10507@selasky.org> <0952027A-5276-487D-99B8-74747B0EEF5D@FreeBSD.org> <55FD23C5.5010008@selasky.org> <64D8263B-1F5D-40E5-994C-479C39B69DC9@neville-neil.com> <1442684369.1224.179.camel@freebsd.org> Cc: George Neville-Neil , Hans Petter Selasky , David Chisnall , Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Bruce Simpson Message-ID: <55FDA1E7.8050007@fastmail.net> Date: Sat, 19 Sep 2015 18:56:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442684369.1224.179.camel@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Sep 2015 17:57:05 -0000 Ian, To paraphrase what I said privately to the various dramatis personae in January: Changes like this need to be reviewed before they go in. As timing is central to the entire OS, change review has to be meticulous, on par with the virtual memory management. We have a VM tsar; we do not have a timing tsar. On 19/09/15 18:39, Ian Lepore wrote: > I'm afraid this message can be interpetted as "reviews are now mandatory > for a 'core component of the system' (whatever that means)". If so, > this would be a Big Change from the last thing I heard about code > reviews, which was basically: as much as some people would like it to be > so, they are not mandatory. ... > a definition as meaningless and vague as[.] I don't believe for one moment that George is advocating for mandatory reviews. But common sense should apply, _as timing is central to the entire OS_. It touches absolutely everything. Hell, I wouldn't feel comfortable checking anything in to e.g. timecounters without at least running it by phk first. So, +1 from me for backout until the change can be reviewed. But to be fair to all involved, perhaps Hans should set out a timeline for how he wants to proceed, subject to the jitter inherent to an all-volunteer project. thanks Bruce