Date: Wed, 7 Dec 2016 14:34:50 -0800 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Mark Johnston <markj@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309658 - head/sys/vm Message-ID: <20161207223450.GP27748@FreeBSD.org> In-Reply-To: <20161207221548.GA33409@wkstn-mjohnston> References: <201612062252.uB6Mqjhr019191@repo.freebsd.org> <20161207212647.GO27748@FreeBSD.org> <20161207221548.GA33409@wkstn-mjohnston>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 07, 2016 at 02:15:49PM -0800, Mark Johnston wrote: M> On Wed, Dec 07, 2016 at 01:26:47PM -0800, Gleb Smirnoff wrote: M> > On Tue, Dec 06, 2016 at 10:52:45PM +0000, Mark Johnston wrote: M> > M> Author: markj M> > M> Date: Tue Dec 6 22:52:45 2016 M> > M> New Revision: 309658 M> > M> URL: https://svnweb.freebsd.org/changeset/base/309658 M> > M> M> > M> Log: M> > M> Provide dummy sysctls for v_cache_count and v_tcached. M> > M> M> > M> Some utilities (notably top(1)) exit if any of their input sysctls don't M> > M> exist, and the removal of the above-mentioned PG_CACHE-related sysctls M> > M> makes it difficult to run such utilities on different versions of the M> > M> kernel without recompiling. M> > M> M> > M> Requested by: bde M> > M> M> > M> Modified: M> > M> head/sys/vm/vm_meter.c M> > M> M> > M> Modified: head/sys/vm/vm_meter.c M> > M> ============================================================================== M> > M> --- head/sys/vm/vm_meter.c Tue Dec 6 22:48:28 2016 (r309657) M> > M> +++ head/sys/vm/vm_meter.c Tue Dec 6 22:52:45 2016 (r309658) M> > M> @@ -314,3 +314,14 @@ VM_STATS_VM(v_forkpages, "VM pages affec M> > M> VM_STATS_VM(v_vforkpages, "VM pages affected by vfork()"); M> > M> VM_STATS_VM(v_rforkpages, "VM pages affected by rfork()"); M> > M> VM_STATS_VM(v_kthreadpages, "VM pages affected by fork() by kernel"); M> > M> + M> > M> +#ifndef BURN_BRIDGES M> > M> +/* M> > M> + * Provide compatibility sysctls for the benefit of old utilities which exit M> > M> + * with an error if they cannot be found. M> > M> + */ M> > M> +SYSCTL_UINT(_vm_stats_vm, OID_AUTO, v_cache_count, CTLFLAG_RD, M> > M> + (u_int *)NULL, 0, "Dummy for compatibility"); M> > M> +SYSCTL_UINT(_vm_stats_vm, OID_AUTO, v_tcached, CTLFLAG_RD, M> > M> + (u_int *)NULL, 0, "Dummy for compatibility"); M> > M> +#endif M> > M> > IMHO, there should be some garbage collecting timeout for them. I'd suggest to M> > delete them from head after stable/12 branch is forked. M> M> The intent was to improve compatibility with old userlands, not just to M> help bridge the transition from 11.0 to 12.0. In general I'm all for M> removing cruft, but these sysctls are unobtrusive and I don't see any M> reason to remove them in a specific time frame provided that nothing M> else breaks compatibility for top(1) (and vmstat(8)). Please feel free M> to add a timeout if you still disagree, though. I'm fine with a bigger timeout. 130000, 140000 or 150000. Anything but the infinity :) -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161207223450.GP27748>