Date: Sat, 17 Mar 2012 16:39:54 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Dimitry Andric <dim@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r233052 - head/share/mk Message-ID: <20120317162754.I1530@besplex.bde.org> In-Reply-To: <201203162319.q2GNJjx5039482@svn.freebsd.org> References: <201203162319.q2GNJjx5039482@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 16 Mar 2012, Dimitry Andric wrote: > Log: > Change the style of share/mk/bsd.sys.mk to that of the other bsd.*.mk > files, and style.Makefile(5), where applicable. While here, update the > link to the gcc warning documentation. Thanks. I rather liked the "^.* foo" style for making ifdefs less unreadable, but it didn't look like it was written here, and it is a sign of other problems that so many nested ifdefs are used. It only used a single space of each level of indentation, so the indentation was still hard too see. The "other bsd.*.mk" files don't include bsd.cpu.mk. This still uses the "^. *foo" style (and is now the only *.mk file one that does this). For assignments, it mostly uses a different unusual style -- just the normal C style of a single space before and after '=' (or '+='). Weird formattings of assignments are harder to grep for than weird formattings of ".foo", so I didn't try looking for them all. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120317162754.I1530>