From owner-cvs-all Thu Jan 30 15: 4:16 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E34F37B401; Thu, 30 Jan 2003 15:04:15 -0800 (PST) Received: from gw.nectar.cc (gw.nectar.cc [208.42.49.153]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8906943F75; Thu, 30 Jan 2003 15:04:14 -0800 (PST) (envelope-from nectar@celabo.org) Received: from opus.celabo.org (opus.celabo.org [10.0.1.111]) by gw.nectar.cc (Postfix) with ESMTP id C0FC54; Thu, 30 Jan 2003 17:04:13 -0600 (CST) Received: by opus.celabo.org (Postfix, from userid 1001) id 5E64B59AC; Thu, 30 Jan 2003 17:02:17 -0600 (CST) Date: Thu, 30 Jan 2003 17:02:17 -0600 From: "Jacques A. Vidrine" To: Tim Robbins Cc: "M. Warner Losh" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdio gets.c Message-ID: <20030130230217.GA75768@opus.celabo.org> Mail-Followup-To: "Jacques A. Vidrine" , Tim Robbins , "M. Warner Losh" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200301301200.h0UC0Qfd081080@repoman.freebsd.org> <20030130.063524.24235010.imp@bsdimp.com> <20030131092613.A48425@dilbert.robbins.dropbear.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030131092613.A48425@dilbert.robbins.dropbear.id.au> X-Url: http://www.celabo.org/ User-Agent: Mutt/1.5.1i-ja.1 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Jan 31, 2003 at 09:26:13AM +1100, Tim Robbins wrote: > On Thu, Jan 30, 2003 at 06:35:24AM -0700, M. Warner Losh wrote: > > > In message: <200301301200.h0UC0Qfd081080@repoman.freebsd.org> > > "Tim J. Robbins" writes: > > : tjr 2003/01/30 04:00:26 PST > > : > > : Modified files: > > : lib/libc/stdio gets.c > > : Log: > > : Remove runtime warning about gets(). > > > > Why? > > Because it's tacky, redundant (we already warn at compile time) > and not worth the space. NetBSD and BSD/OS removed it years ago. > > If you disagree and would like me to back this out, tell me. > I don't feel strongly enough about this to argue. I'd like it backed out, but also find it hard to argue vehemently. It may be tacky, but so what --- applications should never use gets(). I don't find it redundant ... it is easy to miss warnings at compile time yet this is a very dangerous function. I'd be happy to see it removed from libc, to be honest, if ISO C didn't require it. Cheers, -- Jacques A. Vidrine http://www.celabo.org/ NTT/Verio SME . FreeBSD UNIX . Heimdal Kerberos jvidrine@verio.net . nectar@FreeBSD.org . nectar@kth.se To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message