Date: Sat, 31 Aug 2019 00:00:24 +0200 From: Mateusz Guzik <mjguzik@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351622 - head/sys/kern Message-ID: <CAGudoHHg6aYkdCswc=14xippQk_j6wMH24LPtnakcvdCMkRLbQ@mail.gmail.com> In-Reply-To: <20190830102943.GE71821@kib.kiev.ua> References: <201908300045.x7U0jsq9083259@repo.freebsd.org> <20190830102943.GE71821@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/30/19, Konstantin Belousov <kostikbel@gmail.com> wrote: > On Fri, Aug 30, 2019 at 12:45:54AM +0000, Mateusz Guzik wrote: >> + VNASSERT(vp->v_holdcnt > 0 && vp->v_usecount > 0, vp, > A more precise assert condition would also include > vp->v_holdcont >= vp->v_usecount > I agree, but that would be problematic to test for due to other threads playing with these counters. Note this commit was just diff reduction for "usecount implies holdcnt" ( https://reviews.freebsd.org/D21471 ) after which the stronger assertion would not hold. -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHHg6aYkdCswc=14xippQk_j6wMH24LPtnakcvdCMkRLbQ>