Date: Tue, 12 Jul 2011 10:49:11 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Arnaud Lacombe <lacombar@gmail.com> Cc: FreeBSD Current <freebsd-current@FreeBSD.org> Subject: Re: Heavy I/O blocks FreeBSD box for several seconds Message-ID: <4E1BFC77.6080203@FreeBSD.org> In-Reply-To: <CACqU3MW==-XAVxAAoUTuU4CWdzc2isFTu6nnUKRTbnvHF7wLow@mail.gmail.com> References: <4E1421D9.7080808@zedat.fu-berlin.de> <CALH631=F4bSgNDE4w0qcXGMgGxZRRwCP9n-H4M0c%2B1UEaqWr7Q@mail.gmail.com> <4E147F54.40908@zedat.fu-berlin.de> <20110706162811.GA68436@troutmask.apl.washington.edu> <CACqU3MVLr5VXRovs1uV%2BzHazJi2rrjE9Sp3XzsCPJ0Un06pmDQ@mail.gmail.com> <20110706193636.GA69550@troutmask.apl.washington.edu> <4E14CCE5.4050906@zedat.fu-berlin.de> <CAJ-VmomNcbGggbQePi2kBC7uRJm3BenMNKjsqkH5hFLqudsCvg@mail.gmail.com> <20110707015151.GB71966@troutmask.apl.washington.edu> <CAJ-VmongFDGi0amaqod5_NBQcH%2BguA5QMXtttCjTD=ccB==%2BUQ@mail.gmail.com> <CACqU3MVv-YpttXWYnvraR3PT9nh9P1AWMxoXJPevMRhNt4cr5g@mail.gmail.com> <CAJ-VmokC%2BpzoB_x31UGSNt2oRLXfzOK9aXhCMR3FBm7iGEyaAQ@mail.gmail.com> <CACqU3MXVdQfYEBNb9OLnt7CudiBRdvaq3Cd_HXBC8ZrCpmRFvg@mail.gmail.com> <4E1B67C7.8040402@FreeBSD.org> <CACqU3MW==-XAVxAAoUTuU4CWdzc2isFTu6nnUKRTbnvHF7wLow@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
on 12/07/2011 00:48 Arnaud Lacombe said the following: > Hi, > > On Mon, Jul 11, 2011 at 5:14 PM, Andriy Gapon <avg@freebsd.org> wrote: >> on 11/07/2011 23:33 Arnaud Lacombe said the following: >>> For the record, I would like to see enforced public review for _every_ >>> patch *before* it is checked in, as a strong rule. gcc system is >>> particularly interesting. But it is not likely to happen in FreeBSD >>> where FreeBSD committers are clearly more free than other at >>> checking-in un-publicly-reviewed stuff (especially _bad_ stuff). >>> >>> This would of course apply even to long-time committers, no matter how >>> it hurt their ego (which I definitively do not care about). >> >> Have you just volunteered to review all of the patches that I would like to >> commit? And are you prepared to take responsibility for quality of your reviews? >> I am sure that other developers will gladly accept your offer too. >> > _No-one_ can do all the reviews, especially not me (on a purely > technical level). OK, I see, so your plan heavily depends on other people doing something (actually, a lot) according to your ideals. I see how realistic this suggestion is. This is a volunteer project. So, people who want to get something done usually start with themselves, not with telling other people what they should do. > ACK must come from subsystem maintainers. Having > public review would allow the community review, which is now just not > possible today. So far I see that a number of requests for review posted to public mailing lists is greater than a number of actual reviews done. Also, notifications of all changes to the src tree are posted to public mailing lists, so post-commit reviews can also be easily performed. Not seeing too many of those, though. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E1BFC77.6080203>