From owner-cvs-src@FreeBSD.ORG Mon May 5 00:25:19 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B849F37B401; Mon, 5 May 2003 00:25:19 -0700 (PDT) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id C037443F85; Mon, 5 May 2003 00:25:17 -0700 (PDT) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id B52D251A8A; Mon, 5 May 2003 16:55:15 +0930 (CST) Date: Mon, 5 May 2003 16:55:15 +0930 From: Greg 'groggy' Lehey To: Poul-Henning Kamp Message-ID: <20030505072515.GC84427@wantadilla.lemis.com> References: <20030505055618.GA84427@wantadilla.lemis.com> <36667.1052116481@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZNveOOYjKturpEFp" Content-Disposition: inline In-Reply-To: <36667.1052116481@critter.freebsd.dk> User-Agent: Mutt/1.4i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: Deliberately breaking software (was: cvs commit: src/sys/dev/vinum vinumioctl.c) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 May 2003 07:25:20 -0000 --ZNveOOYjKturpEFp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Monday, 5 May 2003 at 8:34:41 +0200, Poul-Henning Kamp wrote: > In message <20030505055618.GA84427@wantadilla.lemis.com>, "Greg 'groggy' Lehey" > writes: > >>>> Forgotten by: phk >>> >>> Nope, I knew about it. >> >> And you broke it anyway? Why? > > No, vinum disregarded how our disk system worked and implemented only > part of the API, that is why you needed a kludge option ("-v") in > newfs for vinum. Compare this to ccd which did not need it. ccd implemented disk labels and partitions. That didn't make sense. But that doesn't answer the question: why did you break something that was working, even if you think the solution was wrong? >> I don't recall that. > > _That_ is not my problem. Yes, it is. You're making claims which you can't substantiate. >> Anyway, you can't force people to maintain software. > > I find it deeply ironic that you say this to distance yourself from > your responsibility as author of vinum, right after trying (and > before for that matter, you try again in this email) to force > me into fixing vinum for you. I never tried to force you to fix Vinum. As should be adequately obvious, you deliberately broke a working interface. >> I relinquished my maintainership for Vinum simply because I >> couldn't work with you. > > That's your choice. It's one that many people make. You are a disruptive influence on the project. > Right now, you still do not use disk_create() to create proper > disk-device in vinum, and that means that features which work with > other disk devices in the system do not work with vinum. Let me rephrase that. I suspect what you meant to say starts with "When I changed the system in February, changing drivers to use disk_create(), I missed out Vinum because...". I'd like to know your reason. If you want to claim that I'm the implicit maintainer, why didn't you tell me about it? And who else can do it? As others have observed, you're referring to undocumented interfaces. There isn't a single comment in the function. How do you expect anybody else to know how to use it? > When do you plan to fix that ? When it's documented. > Or should I simply tell people that disk encryption does not, and > will not ever work with vinum ? Of course not. If you think it's important, fix it. And if you wrote disk_create, document it. As mbp observes, this doesn't belong on this list. If you can think of anything useful to say, please do it in private. Feel free to copy -core. Greg -- See complete headers for address and phone numbers --ZNveOOYjKturpEFp Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQE+thHbIubykFB6QiMRAuBUAKCD9adpUscDkTpdHWeyB6sHft2cPwCgo4YZ e2QRI/LnvV2g2C/G3qRwKgY= =uZna -----END PGP SIGNATURE----- --ZNveOOYjKturpEFp--