Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 19 Jul 2018 13:49:04 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        "Roger Pau Monn?" <royger@freebsd.org>
Cc:        rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r336475 - head/sys/xen/interface/arch-x86/hvm
Message-ID:  <201807192049.w6JKn4c0013553@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <20180719162929.lxklf6pdb3vlmxof@mac>

next in thread | previous in thread | raw e-mail | index | archive | help
> On Thu, Jul 19, 2018 at 07:02:08AM -0700, Rodney W. Grimes wrote:
> > > Author: royger
> > > Date: Thu Jul 19 10:14:52 2018
> > > New Revision: 336475
> > > URL: https://svnweb.freebsd.org/changeset/base/336475
> > > 
> > > Log:
> > >   xen: add missing file from r336474
> > > 
> > > Added:
> > >   head/sys/xen/interface/arch-x86/hvm/start_info.h   (contents, props changed)
> > > 
> > > Added: head/sys/xen/interface/arch-x86/hvm/start_info.h
> > > ==============================================================================
> > > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > > +++ head/sys/xen/interface/arch-x86/hvm/start_info.h	Thu Jul 19 10:14:52 2018	(r336475)
> > > @@ -0,0 +1,159 @@
> > > +/*
> > > + * Permission is hereby granted, free of charge, to any person obtaining a copy
> > > + * of this software and associated documentation files (the "Software"), to
> > > + * deal in the Software without restriction, including without limitation the
> > > + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
> > > + * sell copies of the Software, and to permit persons to whom the Software is
> > > + * furnished to do so, subject to the following conditions:
> > > + *
> > > + * The above copyright notice and this permission notice shall be included in
> > 
> > There is no copyright above.
> > 
> > > + * all copies or substantial portions of the Software.
> > > + *
> > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> > > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> > > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> > > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> > > + * DEALINGS IN THE SOFTWARE.
> > > + *
> > > + * Copyright (c) 2016, Citrix Systems, Inc.
> > 
> > The copyright is below.
> 
> This is a verbatim copy of:
> 
> http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/arch-x86/hvm/start_info.h
> 
> And I'm not intending to modify it locally in the FreeBSD tree, but
> patches can be submitted upstream :).

I agree that it should not be modified localy, howerver you as the person
bringing it into the tree are resposible to insure it has a proper copyright
and license.  Since it does not, and you have been informed of this, and
seem to be unwilling to facilitate it being corrected I would request that
this commit be reverted.  Infact this commit should be reverted until
the copyright and license are of proper form anyway.

> Roger.

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807192049.w6JKn4c0013553>