Date: Thu, 28 Jul 2005 00:57:53 -0700 (PDT) From: Jeremy Chadwick <freebsd@jdc.parodius.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/84211: net-mgmt/mrtg mistakingly deems IPv6 perl modules mandatory Message-ID: <20050728075753.8D5F35E57@mx1.parodius.com> Resent-Message-ID: <200507280800.j6S80Woi073246@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 84211
>Category: ports
>Synopsis: net-mgmt/mrtg mistakingly deems IPv6 perl modules mandatory
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Thu Jul 28 08:00:32 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Jeremy Chadwick
>Release: FreeBSD 4.11-STABLE i386
>Organization:
Parodius Networking
>Environment:
System: FreeBSD pentarou.parodius.com 4.11-STABLE FreeBSD 4.11-STABLE #0: Tue Jul 26 07:02:27 PDT 2005 root@pentarou.parodius.com:/usr/obj/usr/src/sys/PENTAROU i386
>Description:
The port mistakingly deems net/p5-IO-INET6 as a mandatory dependancy for
mrtg. This isn't the case; I took a look at the mrtg code, and support
for IPv6 is optional, with proper perl code to detect if IPv6 modules
are installed or not.
Therefore, we should be honouring WITHOUT_IPV6 for this port.
>How-To-Repeat:
Should be obvious.
>Fix:
Apply below patch.
--- Makefile.orig Tue Jul 26 03:13:47 2005
+++ Makefile Tue Jul 26 03:13:02 2005
@@ -21,8 +21,7 @@
COMMENT= The multi-router traffic grapher
RUN_DEPENDS= ${SITE_PERL}/SNMP_Session.pm:${PORTSDIR}/net-mgmt/p5-SNMP_Session \
- ${SITE_PERL}/Pod/Usage.pm:${PORTSDIR}/textproc/p5-Pod-Parser \
- ${SITE_PERL}/IO/Socket/INET6.pm:${PORTSDIR}/net/p5-IO-INET6
+ ${SITE_PERL}/Pod/Usage.pm:${PORTSDIR}/textproc/p5-Pod-Parser
LIB_DEPENDS= gd.4:${PORTSDIR}/graphics/gd
CONFIGURE_ARGS= --with-gd-lib=${LOCALBASE}/lib \
@@ -40,6 +39,13 @@
mrtg-nw-guide.1 mrtg-reference.1 mrtg-rrd.1 mrtg-squid.1 \
mrtg-unix-guide.1 mrtg-webserver.1 mrtg.1 mrtglib.1
+.include <bsd.port.pre.mk>
+
+# IPv6 support is optional -- mrtg has code to support this
+.if !defined(WITHOUT_IPV6)
+RUN_DEPENDS+= ${SITE_PERL}/IO/Socket/INET6.pm:${PORTSDIR}/net/p5-IO-INET6
+.endif
+
post-patch:
${RM} ${WRKSRC}/lib/mrtg2/BER.pm ${WRKSRC}/lib/mrtg2/SNMP_*.pm
@@ -72,4 +78,4 @@
@${ECHO} "############################################################################"
.endif
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050728075753.8D5F35E57>