From owner-svn-src-all@freebsd.org Sat Jun 15 05:30:59 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B5BEC15BC78A for ; Sat, 15 Jun 2019 05:30:59 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-yw1-xc2a.google.com (mail-yw1-xc2a.google.com [IPv6:2607:f8b0:4864:20::c2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 448D68EA9B for ; Sat, 15 Jun 2019 05:30:59 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-yw1-xc2a.google.com with SMTP id a11so2083506ywc.1 for ; Fri, 14 Jun 2019 22:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RZOG7jW1CErgGwaGRMSLroVshSPVet3qOk+9l7YUpf0=; b=TI+4R/WWptlrRVkmvGM2WQcF4yBwPtMosuWXK4SH1ItLh+WArmiCWAoC3E5tfvF8rd T4sM4c/+D8w1zu1ExPfs8j1J1Mzc5XAtSDQC+ymizChgJmCoXp28yS9+FEN3C+jyaWuj TnkJpii6cjBiujxMgkGUOXfOhNKhlokxh3b/Np2T9/50Ct58AS1p6tbcG0n0soT5q5kY FwIqaBFn0ourMGDno6hfZsqUxV0cOo/3dgHunqaH4EChwLrrh5wQkiWCZcgJxC9u4HP4 con805YEb1ueKtgGey2FodiODGEBKrp3KKeDZ9KA4OuEuxvrS+ItaHDuFeULbh88KYVc mCjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RZOG7jW1CErgGwaGRMSLroVshSPVet3qOk+9l7YUpf0=; b=Ai/QXutSpwAxfWsLvU1TMm8CZ80Tq4zfUpt87dcGA939Xp5BFiPDn19rt5dxFWqNcv sb/Lg7u/zAsl2ieVZKQO3DMK3MFTjUKESL1C0Z/a0ZZktzTFdZBhiEW/uu1HiqpoD87j yco5uymXQPGDUYqB8b5SMLOOsxi3XXf2BuDmBE9CWiUSDmFdnNWQBim9rJDKEvzWxHuQ u4VUQyjeNES57Yffk3DB85LdCQgh2vVlkZjv/aMnB6vQf45azxBOgKK7lO0mzwTTdsMA PM1TCC4/tREv4f5BHTg5N3vfJHowO6lUQXGGmP5Q5OQS6YH0cus5Sy7MDcac2JNaHFrF I5PQ== X-Gm-Message-State: APjAAAUqMcN67im0pDPdnMGicd2Zi2w8MUFGcYe6BBxfaeHDlDR0/6Um qdl2PMiGuEsMhB+x6oASNkmutzAbB4J7k3TU6b3mq6PJtJ0= X-Google-Smtp-Source: APXvYqzzJtQnCybgWGZCKITg6hALyGeUhS4Si5eXXiRneK1KoX/7W0be9mNO3HB3S49N2BjjkwQ9iPj7sf2+IS9WxRs= X-Received: by 2002:a81:7d07:: with SMTP id y7mr6938813ywc.377.1560576658426; Fri, 14 Jun 2019 22:30:58 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:4a86:0:0:0:0:0 with HTTP; Fri, 14 Jun 2019 22:30:57 -0700 (PDT) In-Reply-To: <201906150430.x5F4UDVX031215@repo.freebsd.org> References: <201906150430.x5F4UDVX031215@repo.freebsd.org> From: Oliver Pinter Date: Sat, 15 Jun 2019 07:30:57 +0200 Message-ID: Subject: Re: svn commit: r349046 - head/sys/vm To: Doug Moore Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" X-Rspamd-Queue-Id: 448D68EA9B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jun 2019 05:31:00 -0000 On Saturday, June 15, 2019, Doug Moore wrote: > Author: dougm > Date: Sat Jun 15 04:30:13 2019 > New Revision: 349046 > URL: https://svnweb.freebsd.org/changeset/base/349046 > > Log: > Critical comments were lost in r349203. This patch seeks to restore > the lost information in new comments. > > Reported by: alc > Reviewed by: alc > Approved by: kib (mentor) > Differential Revision: https://reviews.freebsd.org/D20632 > > Modified: > head/sys/vm/vm_map.c > > Modified: head/sys/vm/vm_map.c > ============================================================ > ================== > --- head/sys/vm/vm_map.c Sat Jun 15 01:27:49 2019 (r349045) > +++ head/sys/vm/vm_map.c Sat Jun 15 04:30:13 2019 (r349046) > @@ -2186,17 +2186,22 @@ _vm_map_clip_start(vm_map_t map, vm_map_entry_t > entry, > VM_MAP_ASSERT_LOCKED(map); > KASSERT(entry->end > start && entry->start < start, > ("_vm_map_clip_start: invalid clip of entry %p", entry)); > + vm_map_simplify_entry(map, entry); Hi! This isn't just comment. > > /* > - * Split off the front portion -- note that we must insert the new > - * entry BEFORE this one, so that this entry has the specified > - * starting address. > + * Create a backing object now, if none exists, so that more > individual > + * objects won't be created after the map entry is split. > */ > - vm_map_simplify_entry(map, entry); > vm_map_entry_charge_object(map, entry); > + > + /* Clone the entry. */ > new_entry = vm_map_entry_create(map); > *new_entry = *entry; > > + /* > + * Split off the front portion. Insert the new entry BEFORE this > one, > + * so that this entry has the specified starting address. > + */ > new_entry->end = start; > entry->offset += (start - entry->start); > entry->start = start; > @@ -2244,14 +2249,20 @@ _vm_map_clip_end(vm_map_t map, vm_map_entry_t > entry, v > KASSERT(entry->start < end && entry->end > end, > ("_vm_map_clip_end: invalid clip of entry %p", entry)); > > - > /* > - * Create a new entry and insert it AFTER the specified entry > + * Create a backing object now, if none exists, so that more > individual > + * objects won't be created after the map entry is split. > */ > vm_map_entry_charge_object(map, entry); > + > + /* Clone the entry. */ > new_entry = vm_map_entry_create(map); > *new_entry = *entry; > > + /* > + * Split off the back portion. Insert the new entry AFTER this > one, > + * so that this entry has the specified ending address. > + */ > new_entry->start = entry->end = end; > new_entry->offset += (end - entry->start); > if (new_entry->cred != NULL) > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >