From owner-freebsd-rc@FreeBSD.ORG Mon Jan 25 20:44:21 2010 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 972CC1065693 for ; Mon, 25 Jan 2010 20:44:21 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 2BA358FC17 for ; Mon, 25 Jan 2010 20:44:20 +0000 (UTC) Received: (qmail 12784 invoked by uid 399); 25 Jan 2010 20:44:20 -0000 Received: from localhost (HELO ?192.168.0.110?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 25 Jan 2010 20:44:20 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4B5E02A3.4050708@FreeBSD.org> Date: Mon, 25 Jan 2010 12:44:19 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.7) Gecko/20100111 Thunderbird/3.0.1 MIME-Version: 1.0 To: Ed Maste References: <20100125195748.GA30798@sandvine.com> In-Reply-To: <20100125195748.GA30798@sandvine.com> X-Enigmail-Version: 1.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: NetBSD compat shims in rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jan 2010 20:44:21 -0000 No objection. It's been "on the list" for a long time, never got around to actually doing something about it. :) Doug On 1/25/2010 11:57 AM, Ed Maste wrote: > There's a vestigial bit of NetBSD compat shim in rc.subr that I'd > like to clean up; any objections to the patch below? > > Index: etc/rc.subr > =================================================================== > --- etc/rc.subr (revision 202731) > +++ etc/rc.subr (working copy) > @@ -52,22 +52,12 @@ > > SYSCTL="/sbin/sysctl" > SYSCTL_N="${SYSCTL} -n" > -CMD_OSTYPE="${SYSCTL_N} kern.ostype" > -OSTYPE=`${CMD_OSTYPE}` > +SYSCTL_W="${SYSCTL}" > ID="/usr/bin/id" > IDCMD="if [ -x $ID ]; then $ID -un; fi" > PS="/bin/ps -ww" > JID=`$PS -p $$ -o jid=` > > -case ${OSTYPE} in > -FreeBSD) > - SYSCTL_W="${SYSCTL}" > - ;; > -NetBSD) > - SYSCTL_W="${SYSCTL} -w" > - ;; > -esac > - > # > # functions > # --------- > _______________________________________________ > freebsd-rc@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-rc > To unsubscribe, send any mail to "freebsd-rc-unsubscribe@freebsd.org" > -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso