From owner-svn-src-all@freebsd.org Fri Jul 29 16:24:33 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7FAB0BA7303; Fri, 29 Jul 2016 16:24:33 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-oi0-x230.google.com (mail-oi0-x230.google.com [IPv6:2607:f8b0:4003:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 42F331B76; Fri, 29 Jul 2016 16:24:33 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-oi0-x230.google.com with SMTP id w18so113062155oiw.3; Fri, 29 Jul 2016 09:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IhAiyfzVv+bLnbB32YUfzkQYY5qBIupWdPaytKO5lvs=; b=OwpnjhylJVObobQypb6mjnLRpPyJE+QB3kfDHHIkVymiN8xgAvUTcGDD7roGtkj1/6 W6cRkbzVfRF4X27snQ9g5+rgUCvJvTDxOkcolXsiWTlDoTAyHwK9pRSUXOI8iFA/4ukk wQPGjbnCgOqWfIWsiOVgLaUAiP4LqIqgPPmHkkL0IFNd3+aYCNftEI1YPqHs5K8ZDlFn coXyxR1j4E6Gztl/ypK9mVlqhx77QRAEoNTN3PPMikfSq0G85kwSlVbd5vILhOgGe0XH SQ9Lrj3Q3LAxaLhflxpQ+9XsX/AuFHZsX15gTt2t25Nh98tM2cuG5cMADlAtJm8oy7y0 0o8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IhAiyfzVv+bLnbB32YUfzkQYY5qBIupWdPaytKO5lvs=; b=G7B64rETjwhLJFLFIRqAzRxjTwXfivRa/V5Mqfik9oMvCYMNtWUePKEPGHh6PoFgcG 8XFXgGnjNOvRcPn5SzIJzf6Y0zei/1VYVJ4mXjEtypRkFciQ8hMPQENEXejbb7+TCGvB AbDTSeaoQ8HAG13VJTAeZglulc/lAxbz92rrZAM4keFrrzgNDC8NGqED/G2hrH5/WFry EUTCYS1bcsPPJ+g7e3YSsbESWt4VNNoC+ehjr0hY48ihayrPIQ3NPLJ7M189a7z0grtC gnF119BOn4NvzcfAB7eS87U/mClX8/8RU96Mewp+mh67rnxrmM+42iiZrsbIHz3TEavn 83tQ== X-Gm-Message-State: AEkooutxrHMScyUvEEw/2McFfKtbaspD1JnAs6POpU8POZhbYWIpy3yNHMeCR4Yusn4zyk0beKPBtax/JWJFMQ== X-Received: by 10.202.222.70 with SMTP id v67mr5617807oig.194.1469809472454; Fri, 29 Jul 2016 09:24:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.44.176 with HTTP; Fri, 29 Jul 2016 09:24:31 -0700 (PDT) In-Reply-To: References: <201607291617.u6TGHsPE060673@repo.freebsd.org> From: Benjamin Kaduk Date: Fri, 29 Jul 2016 11:24:31 -0500 Message-ID: Subject: Re: svn commit: r303484 - head/usr.bin/indent To: "Pedro F. Giffuni" Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2016 16:24:33 -0000 On Fri, Jul 29, 2016 at 11:20 AM, Benjamin Kaduk wrote: > On Fri, Jul 29, 2016 at 11:17 AM, Pedro F. Giffuni > wrote: > >> Author: pfg >> Date: Fri Jul 29 16:17:54 2016 >> New Revision: 303484 >> URL: https://svnweb.freebsd.org/changeset/base/303484 >> >> Log: >> indent(1): Fix breakage caused by single comment following "else". >> >> indent(1) simply wasn't taught that "else" may be followed by a comment >> without any opening brace anywhere on the line, so it was very confused >> in such cases. >> >> > Wrong commit message? I see no 'else' in this change. > (I guess core's guidance is to revert and recommit with correct message, > these days.) > Nevermind, I think I see what's going on here, now. -Ben