Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 Aug 2013 09:51:01 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Antoine Brodin <antoine@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r324150 - head/astro/aa
Message-ID:  <20130802075101.GB18976@ithaqua.etoilebsd.net>
In-Reply-To: <201308020748.r727m8hd036121@svn.freebsd.org>
References:  <201308020748.r727m8hd036121@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--R3G7APHDIzY6R/pk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 02, 2013 at 07:48:08AM +0000, Antoine Brodin wrote:
> Author: antoine
> Date: Fri Aug  2 07:48:07 2013
> New Revision: 324150
> URL: http://svnweb.freebsd.org/changeset/ports/324150
>=20
> Log:
>   Fix without gcc
>=20
> Modified:
>   head/astro/aa/Makefile
>=20
> Modified: head/astro/aa/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/astro/aa/Makefile	Fri Aug  2 07:32:02 2013	(r324149)
> +++ head/astro/aa/Makefile	Fri Aug  2 07:48:07 2013	(r324150)
> @@ -32,7 +32,7 @@ post-patch:
>  	@${REINPLACE_CMD} \
>  		's|%%PREFIX%%|${PREFIX}|g ; s|%%DATADIR%%|${DATADIR}|g' \
>  		${WRKSRC}/kfiles.c
> -	@${REINPLACE_CMD} 's|CFLAGS=3D  -O2|CFLAGS+=3D|' ${WRKSRC}/makefile
> +	@${REINPLACE_CMD} 's|CFLAGS=3D  -O2|CFLAGS+=3D| ; s|CC=3D|CC?=3D|' ${WR=
KSRC}/makefile

Why not using MAKE_ARGS=3D CC=3D${CC} here?

That is how make(1) is designed to work, All variable are always overwritab=
le by
args, ?=3D is only to allow to overwrite from env.

regards,
Bapt

--R3G7APHDIzY6R/pk
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlH7ZOUACgkQ8kTtMUmk6EzZPQCfRrPY+kpQEc4IUJRIH8oAA4nw
ZNoAoKn1Ej5TNJ0LDPBQ1hM+wA4I7QIl
=81XY
-----END PGP SIGNATURE-----

--R3G7APHDIzY6R/pk--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130802075101.GB18976>