Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 3 Dec 2015 22:39:42 +0000 (UTC)
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r291725 - head/share/mk
Message-ID:  <201512032239.tB3MdgSE066406@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bdrewery
Date: Thu Dec  3 22:39:42 2015
New Revision: 291725
URL: https://svnweb.freebsd.org/changeset/base/291725

Log:
  Revert r288966 as it is redundant and not right.
  
  bsd.prog.mk and bsd.lib.mk already make OBJS depend on headers when there is
  not .OBJDIR/.depend file, which is still true for the initial meta mode builds.
  If there was something to benefit the meta mode build here then it should be
  extended to the non-meta mode build as well.
  
  Some of the problems here were just DPSRCS being hooked up wrongly, fixed in
  r291330.
  
  The logic itself is flawed as 'buildfiles' is in a different part of the
  dependency tree than the objects and headers are, so the objects will still be
  built independent from 'buildfiles'.  'buildfiles' is not ordered in the build
  before objects.
  
  Sponsored by:	EMC / Isilon Storage Division

Modified:
  head/share/mk/local.autodep.mk

Modified: head/share/mk/local.autodep.mk
==============================================================================
--- head/share/mk/local.autodep.mk	Thu Dec  3 22:07:01 2015	(r291724)
+++ head/share/mk/local.autodep.mk	Thu Dec  3 22:39:42 2015	(r291725)
@@ -14,12 +14,6 @@ LDFLAGS+= ${LDFLAGS_LAST}
 
 CLEANFILES+= .depend
 
-.for h in ${SRCS:M*.h}
-.if target($h)
-buildfiles: $h
-.endif
-.endfor
-
 # handy for debugging
 .SUFFIXES:  .S .c .cc .cpp .cpp-out
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201512032239.tB3MdgSE066406>