Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 Apr 2015 08:12:00 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Kurt Jaeger <pi@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r384140 - in head/math/coinmp: . files
Message-ID:  <20150417081159.GA53939@FreeBSD.org>
In-Reply-To: <201504170802.t3H82ZOI017313@svn.freebsd.org>
References:  <201504170802.t3H82ZOI017313@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 17, 2015 at 08:02:35AM +0000, Kurt Jaeger wrote:
> New Revision: 384140
> URL: https://svnweb.freebsd.org/changeset/ports/384140
> 
> Log:
>   math/coinmp: 1.8.0 -> 1.8.1
>   
>   - Minor fixes
> [...]
>  MAINTAINER=	cpm@fbsd.es
> -COMMENT=	Optimization library with support for COIN-OR CLP, CBC, and CGL
> +COMMENT=	Optimization library with support for COIN-OR, CLP, CBC and CGL

In FreeBSD we respect Oxford comma.  Notice that it was there before.

>  check regression-test test: build
> -	@(cd ${WRKSRC};  ${SETENV} ${MAKE_ENV} ${MAKE} ${_MAKE_JOBS} \
> +	@(cd ${WRKSRC}; ${SETENV} ${MAKE_ENV} ${MAKE} ${_MAKE_JOBS} \

If you decided to change this line for no real reason, you could've also
replaced it with something like this to avoid explicit "cd" and two-command
construct (longer and less readable, requires subshell, etc.):

	@${SETENV} ${MAKE_ENV} ${MAKE} ${_MAKE_JOBS} ... -C ${WRKSRC}

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150417081159.GA53939>