From owner-svn-ports-all@FreeBSD.ORG  Fri Apr 17 08:12:00 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 04434623; Fri, 17 Apr 2015 08:12:00 +0000 (UTC)
Date: Fri, 17 Apr 2015 08:12:00 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Kurt Jaeger <pi@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r384140 - in head/math/coinmp: . files
Message-ID: <20150417081159.GA53939@FreeBSD.org>
References: <201504170802.t3H82ZOI017313@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201504170802.t3H82ZOI017313@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Apr 2015 08:12:00 -0000

On Fri, Apr 17, 2015 at 08:02:35AM +0000, Kurt Jaeger wrote:
> New Revision: 384140
> URL: https://svnweb.freebsd.org/changeset/ports/384140
> 
> Log:
>   math/coinmp: 1.8.0 -> 1.8.1
>   
>   - Minor fixes
> [...]
>  MAINTAINER=	cpm@fbsd.es
> -COMMENT=	Optimization library with support for COIN-OR CLP, CBC, and CGL
> +COMMENT=	Optimization library with support for COIN-OR, CLP, CBC and CGL

In FreeBSD we respect Oxford comma.  Notice that it was there before.

>  check regression-test test: build
> -	@(cd ${WRKSRC};  ${SETENV} ${MAKE_ENV} ${MAKE} ${_MAKE_JOBS} \
> +	@(cd ${WRKSRC}; ${SETENV} ${MAKE_ENV} ${MAKE} ${_MAKE_JOBS} \

If you decided to change this line for no real reason, you could've also
replaced it with something like this to avoid explicit "cd" and two-command
construct (longer and less readable, requires subshell, etc.):

	@${SETENV} ${MAKE_ENV} ${MAKE} ${_MAKE_JOBS} ... -C ${WRKSRC}

./danfe