From owner-svn-ports-head@freebsd.org Tue Jul 2 08:26:08 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AF33515CC0FB; Tue, 2 Jul 2019 08:26:08 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 50C5E73D00; Tue, 2 Jul 2019 08:26:08 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 3209EBA66; Tue, 2 Jul 2019 08:26:08 +0000 (UTC) Date: Tue, 2 Jul 2019 08:26:08 +0000 From: Alexey Dokuchaev To: Piotr Kubaj Cc: Greg Lewis , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505640 - head/java/openjdk11 Message-ID: <20190702082607.GA45590@FreeBSD.org> References: <201907012118.x61LIIQr011692@repo.freebsd.org> <20190702072450.GA17073@KGPE-D16> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190702072450.GA17073@KGPE-D16> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 50C5E73D00 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.95)[-0.947,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jul 2019 08:26:08 -0000 On Tue, Jul 02, 2019 at 09:24:50AM +0200, Piotr Kubaj wrote: > Why not use USES=compiler:c11 instead of setting manually USE_GCC=yes? Technically they're semantically not the same; while pulling C11-capable compiler might fix the problem, you're still telling the reader that you're pulling C11-capable compiler, while USE_GCC means that you want GCC, devoid of particular reasons. In practice, compiler:c11 often used as compiler:modern. I'd welcome this spelling: it would actually make things more clear because now people often abuse compiler:c11 or (even worse) compiler:c++11-lang for 98/99 code which gcc-4.2 cannot eat, or because one of the dependencies requires new compiler (majority of cases). ./danfe P.S. Sorry for lack of context due to prior top-posting.